Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 10473 - add support to src_unpack/unpack to utilize the 'file' command
Summary: add support to src_unpack/unpack to utilize the 'file' command
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Unclassified (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Nicholas Jones (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-11-09 04:12 UTC by SpanKY
Modified: 2011-10-30 22:20 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SpanKY gentoo-dev 2002-11-09 04:12:21 UTC
a lot of ebuilds download files that are in a format that are not to be  
'unpacked'  
  
sometimes SRC_URI has values like:  
doc? ( grab a pdf/txt/etc... file )  
  
the default src_unpack file would fail on this because it does not end in a 
recognizable file type ... which in turn leads to imo src_unpack functions in 
the ebuild that shouldnt have to exist ... 
src_unpack() { 
	unpack ${P}.tar.gz 
	#unpack ${P}.pdf 
} 
 
i'd suggest adding the ability to run 'file' on files that do not match the 
default cases (or let file determine from the start which case to run).  this 
way for files that are of type 'ASCII text' or something else, the src_unpack 
doesnt do anything ... 
 
or maybe just remove the die command under the '*)' case altogether and add a 
big old 'einfo' or 'ewarn' to src_unpack ...
Comment 1 Nicholas Jones (RETIRED) gentoo-dev 2002-11-13 00:06:14 UTC
Removed the die case.