Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 104324 - Patches for building app-text/html2text on ppc-macos
Summary: Patches for building app-text/html2text on ppc-macos
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Mac OSX (show other bugs)
Hardware: All OS X
: High normal
Assignee: Gentoo for Mac OS X
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2005-08-30 18:24 UTC by Thomas Kjosmoen
Modified: 2006-04-12 10:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
html2text-1.3.2.ebuild.patch (html2text-1.3.2.ebuild.patch,721 bytes, patch)
2005-08-30 18:25 UTC, Thomas Kjosmoen
Details | Diff
html2text-osx.patch (html2text-osx.patch,427 bytes, patch)
2005-08-30 18:27 UTC, Thomas Kjosmoen
Details | Diff
Ebuild patch, patch only for OS X (html2text-1.3.2.ebuild.patch,289 bytes, patch)
2005-10-16 05:22 UTC, Thomas Kjosmoen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Kjosmoen 2005-08-30 18:24:17 UTC
These patches makes html2text work on ppc-macos. The patches shouldn't interfere or have any influence 
on other platforms. 

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Thomas Kjosmoen 2005-08-30 18:25:54 UTC
Created attachment 67304 [details, diff]
html2text-1.3.2.ebuild.patch

Enables the patching for 1.3.2a if gcc has version 3.3 and higher OR 4 and
higher.
Comment 2 Thomas Kjosmoen 2005-08-30 18:27:09 UTC
Created attachment 67305 [details, diff]
html2text-osx.patch

This patch fixes compilation errors.
Comment 3 Fabian Groffen gentoo-dev 2005-08-31 04:47:04 UTC
the -e is purely cosmetic (upstream should have used echo -n IMHO), so I dropped it.

Made rest of the patch unconditional, as it seems not to harm x86.

Tested it with html2text http://www.gentoo.org/ and html2text
http://monetdb.cwi.nl/ : worked fine

Marked ~ppc-macos in CVS
Comment 4 Arnaud Launay 2005-10-16 01:01:17 UTC
This patch broke things in the outer world, please have a look at #105051, we
need advice on what you need
Comment 5 Thomas Kjosmoen 2005-10-16 05:18:46 UTC
I believe the line:
epatch ${FILESDIR}/${P}-darwin.patch

should be changed to (as I had in my submitted patch):
use ppc-macos && epatch ${FILESDIR}/${P}-darwin.patch

since this is a patch that only applies to OS X.

I'll add a new patch that solves this problem. Should I reopen this bug?
Comment 6 Thomas Kjosmoen 2005-10-16 05:22:59 UTC
Created attachment 70787 [details, diff]
Ebuild patch, patch only for OS X

This patch applies to the current 1.3.2 ebuild in portage, and it will only
patch for OS X. There shouldn't be any reason to patch for non-OS X.
Comment 7 Fabian Groffen gentoo-dev 2005-10-16 06:47:36 UTC
see other bug for the solution.

We don't want conditional patches, they are bad and hard to maintain.