Please find attached canlock-2b.ebuild. Not sure if I got the licence right, but as far as I could tell that's how it appears to be. Keywords have been set in accordance with the README, plus my personal experience (amd64). Canlock is a small library for handling Usenet cancel locks. At least two readers I know of use it (slrn natively, tin with a patch), so it might be worth including into portage. My suggestion for its place in the repository is net-libs/canlock.
Created attachment 67254 [details] canlock-2b.ebuild
1/ We cannot include this with a missing header. 2/ Keywords do not follow policy. 3/ No need to DEPEND/RDEPEND on libc, also you should not set RDEPEND to DEPEND. 4/ Licenses need to be separated by space, not comma. 5/ ${S} should be quoted 6/ src_install () is invalid, needs to be src_install() http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=3 http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=1 Please, fix the above problems and reopen.
Created attachment 67265 [details] canlock-2b.ebuild Sorry about that, I was basing mostly on other ebuilds and haven't read the whole developer's handbook yet. Hope it will be better this time.
New version of ebuild posted.
Looks good now. One more question - did you really test this on all the ARCHs in KEYWORDS? If not, then leave only those tested. Thanks.
Created attachment 67277 [details] canlock-2b.ebuild Removed two architectures I haven't personally tested building canlock on (although the upstream README does claim both Alpha and Itanium are supported).
* No need to cd ${S}. * No documentation? Please reopen with an attached ebuild.
Created attachment 67405 [details] canlock-2b.ebuild
New ebuild posted.
So... Anything more I could do to have this package accepted?
Upstream link at http://homepage.mac.com/imeowbot/iblog/C1355421991/ is dead, however debian has a copy of it in their testing repo as well as stable: http://packages.qa.debian.org/c/canlock.html If we can identify upstream this might be worth at least putting into sunrise especially with the work put into the ebuild.
Created attachment 227297 [details] working canlock ebuild I did a rework of the last ebuild, changed sources and diff. My versioning scheme seems to fit better. (But it's only my opinion) regards, Sebastian
Created attachment 227327 [details] canlock-2b.ebuild Changes for previously posted ebuilds: * Use EAPI 2 for src_prepare phase * Use debian mirror for the SRC_URI * Explicitly specify no deps/rdeps needed * Rework the ebuild some more to simplify applying the debian patch * Install only necessary files -- test binaries (canlocktest and hmactest) only needed for running tests before installing (which pass for me) * Use multilib eclass for the get_libdir function Note that there is still a minor bug with parallel make jobs that appears to be caused by the code from the debian patch.
(In reply to comment #13) > Changes for previously posted ebuilds: > * Use EAPI 2 for src_prepare phase > * Use debian mirror for the SRC_URI > * Explicitly specify no deps/rdeps needed > * Rework the ebuild some more to simplify applying the debian patch > * Install only necessary files -- test binaries (canlocktest and hmactest) > only needed for running tests before installing (which pass for me) > * Use multilib eclass for the get_libdir function Rad! Thanks a lot. Sebastian
Added to CVS.
