Bug 104071 – x-modular.eclass -- DRIVER_OPTIONS and --disable-static

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Torsten Veller (RETIRED) 2005-08-28 15:18:31 UTC]

| # If we're a driver package
| if [[ "${PN/#xf86-video}" != "${PN}" ]] | [[ "${PN}" != "xf86-input" ]]; then
|         # Don't build static driver modules
|         DRIVER_OPTIONS="--disable-static"
| fi


seems to be wrong.
Do you want:
if [[ "${PN/#xf86-video}" != "${PN}" ]] || [[ "${PN/#xf86-input}" != "${PN}" ]];
then
?

[Comment 1 Doug Goldstein (RETIRED) 2005-09-03 14:08:42 UTC]

According to Spanky, it can further be simplified down to...

if [[ "${PN/#xf86-video}" != "${PN}" || "${PN/#xf86-input}" != "${PN}" ]];
then

But Tove is correct. The eclass is wrong.

I'll fix it.

[Comment 2 Doug Goldstein (RETIRED) 2005-09-03 14:10:17 UTC]

Proof the change worked..


>>> Merging x11-drivers/xf86-input-mouse-1.0.0 to /
--- /usr/
--- /usr/lib/
--- /usr/lib/xorg/
--- /usr/lib/xorg/modules/
--- /usr/lib/xorg/modules/input/
>>> /usr/lib/xorg/modules/input/mouse_drv.so
--- /usr/share/
--- /usr/share/man/
--- /usr/share/man/man4/
>>> /usr/share/man/man4/mouse.4.gz
>>> Safely unmerging already-installed instance...
--- !mtime obj /usr/share/man/man4/mouse.4.gz
--- !mtime obj /usr/lib/xorg/modules/input/mouse_drv.so
<<<        obj /usr/lib/xorg/modules/input/mouse_drv.la
<<<        obj /usr/lib/xorg/modules/input/mouse_drv.a
--- !empty dir /usr/share/man/man4
--- !empty dir /usr/share/man
--- !empty dir /usr/share
--- !empty dir /usr/lib/xorg/modules/input
--- !empty dir /usr/lib/xorg/modules
--- !empty dir /usr/lib/xorg
--- !empty dir /usr/lib
--- !empty dir /usr
>>> original instance of package unmerged safely.

[Comment 3 Donnie Berkholz (RETIRED) 2005-09-05 16:56:15 UTC]

I "de-simplified" this in the interest of clarity -- the original suggestion
seems clearer to me.

Thanks to both of you!