Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 104046 - SILC-Plugin: Ebuild patches without checking for Irssi version
Summary: SILC-Plugin: Ebuild patches without checking for Irssi version
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor
Assignee: Packages in net-irc
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-28 09:42 UTC by Daniel Link
Modified: 2005-08-30 07:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Link 2005-08-28 09:42:04 UTC
I just had a conversation with the SILC-plugin developer about an issue which
seems to be caused by Gentoo's silc-plugin ebuild. Irssi has changed it's
setting "term_type" to "term_charset" from version 0.8.9 to 0.8.10. The ebuild
includes a patch for this but doesn't check which version of Irssi is installed.
This leads to "Cannot find term_type variable" warnings in Irssi 0.8.9. I'm not
sure whether this happens always or only when special (non-ASCII) characters are
typed. It works fine with (masked) Irssi version 0.8.10 though.

Reproducible: Always
Steps to Reproduce:
1. Install Irssi 0.8.9 and silc-plugin
2. Optional: make Irssi UTF-8 ready and set term_type to UTF-8
3. Start Irssi and load silc-plugin
4. Type some special characters like 
Comment 1 Daniel Link 2005-08-28 09:42:04 UTC
I just had a conversation with the SILC-plugin developer about an issue which
seems to be caused by Gentoo's silc-plugin ebuild. Irssi has changed it's
setting "term_type" to "term_charset" from version 0.8.9 to 0.8.10. The ebuild
includes a patch for this but doesn't check which version of Irssi is installed.
This leads to "Cannot find term_type variable" warnings in Irssi 0.8.9. I'm not
sure whether this happens always or only when special (non-ASCII) characters are
typed. It works fine with (masked) Irssi version 0.8.10 though.

Reproducible: Always
Steps to Reproduce:
1. Install Irssi 0.8.9 and silc-plugin
2. Optional: make Irssi UTF-8 ready and set term_type to UTF-8
3. Start Irssi and load silc-plugin
4. Type some special characters like äöü

Actual Results:  
Warnings appeared in the first Irssi window

Expected Results:  
Be aware that "term_charset" is still named "term_type" in versions <0.8.10.
Comment 2 Andrej Kacian (RETIRED) gentoo-dev 2005-08-29 08:04:35 UTC
I'm really sorry, that was an oversight on my part. Freshly committed 1.0.1-r4
now checks (has_version) for installed irssi, and adjusts the source accordingly.
Thanks for reporting.
Comment 3 Daniel Link 2005-08-30 03:32:17 UTC
Great, now I get an error with Irssi 0.8.10 :D

12:30 -!- Irssi: warning settings_get_default_str(term_type) : unknown setting
12:30 -!- Irssi: warning settings_get(term_type) : not found
Comment 4 Andrej Kacian (RETIRED) gentoo-dev 2005-08-30 07:34:12 UTC
Ah, 0.8.10_rc5 is not >=0.8.10. Fixed, please resync.