We'd like for a commits alias to be set up for the subversion portage module. It'd be nice if the actual diff could be attached on commit mails, but just the commit message and files affected would be sufficient.
Not to be pushy, but there's a small amount of urgency on this one. Apparently, there's a few things that need to be done by separate people. The list, as far as I can tell, is as follows but anybody who knows better please step up and correct it. 1) Script that plugs into subversion that sends mails locally. 2) A alias on the subversion server that forwards mails to toucan. 3) The alias on toucan for devs to add themselves to.
might as well do this in general for everyone ... be nice to have this on the sandbox and baselayout modules as well
Ok, this is ready to test. a commit to the portage svn module should fire a note to portage-commits which consists of ferringb, jstubbs, and myself for now. Others can add themselves to /var/mail/alias/misc/portage-commits on toucan. If this works fine I can add other modules as requested. -C
It's working beautifully. Thanks!
If we went global with this then it would be an all-or-nothing gig (meaning mail would be spit out for repos that are not setup with an alias, etc) and could possibly create a lot of unnecessary mail. So, I think I would rather see an opt-in system. SpanKY, who needs to be on the sandbox-commits and baselayout-commits aliases?
sandbox: vapier / azarah (and probably the portage guys ...) baselayout: vapier / azarah / uberlord not quite sure what you mean about the all or nothing ... i wouldnt want to see e-mail for repos like eselect ...
Right. We can shoot the email off from one of two post-commit scripts. The first is a repo-specific script, the second is fired off after a commit to any and every repo. The latter is easier to handle administratively, yet not every repo will want it, so the former is probably the better way to go (and handle them per-request) Anyway. the baselayout and sandbox commit messages are done. users can add themselves in /var/mail/alias/misc on toucan Closing the bug. Cheers!
umm.. think it chokes on multi file commits. commited to portage/2.0/{ChangeLog,bin/ebuild,pym/portage.py} and no mail :)
doesn't make much since as an svn repo revision increments only once when multiple files are changed. Nevertheless, I've tweaked the script a bit. Please try again and let me know. (I put myself onto the portage-commits alias, but I won't know if you try and it's still borked) Cheers
Offhand, it's plain not relaying any commits at this point :) roughly 09:55 utc of 10/05 was a commit fex, that didn't come through mail wise.
fixed (and tested).. fixed the other 2 repos also closing the bug
Could someone change the script so it only sends mails for the main/ module in the repo?
Well, long delay on this bug. I changed the post-commit hook to /var/svnroot/scripts/commit-email.pl ${REPOS} ${REV} -m main portage-commits@gentoo.org This should cover everything in main with the regexp "main". Please test.
The portage-commits hook seems to be broken. The last mail that I received was for r6542 on May 17 and we're at r6564 now. It stopped at the same time that bug 169930 got fixed.
refixed. pylon had commented out the mail line
(In reply to comment #15) > pylon had commented out the mail line Oops, sorry. It was late in the night when I tried to fix that other bug…
