Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 103586 - saving malfunctions in slashem-0.760 and forward
Summary: saving malfunctions in slashem-0.760 and forward
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-24 07:24 UTC by psyill.net
Modified: 2006-10-06 09:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
A corrected version of the RedHat9 configuration file (RedHat9.configure,1.28 KB, text/plain)
2005-08-24 07:28 UTC, psyill.net
Details
Remove obsolete VAR_PLAYGROUND and LOCKDIR defines (103586.diff,1.97 KB, patch)
2005-08-28 08:59 UTC, Pekka Rousu
Details | Diff
Latest version of my patch (slashem.patch,4.76 KB, patch)
2006-10-05 15:50 UTC, Pekka Rousu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description psyill.net 2005-08-24 07:24:33 UTC
In SlashEm v. 0.7E6 and forward, trying to save your game results in SlashEm
responding with an error message. SlashEm can't seem to find a certain file and
compression of the save file fails.
What happens is that SlashEm tries to find gzip to do the compression but looks
for it in the wrong place. This is due to a problem with the installation
procedure in the ebuilds. When updating "#define"-sections in the headers a
configuration file for RedHat9 systems is used which sets the path to gzip to
/usr/bin/gzip, but in gentoo systems the path should be /bin/gzip.
The solution is to put a corrected version of the configuration file in the
files/0.0.7E6- or files/0.0.7E7-directory inside slashem's portage directory,
thus including it in the configuration process.

Reproducible: Always
Steps to Reproduce:
1. Emerge >=games-roguelike/slashem-0.0.760
2. Run slashem and start a new game
3. Save

Actual Results:  
Saving fails

Expected Results:  
Saving works
Comment 1 psyill.net 2005-08-24 07:28:13 UTC
Created attachment 66753 [details]
A corrected version of the RedHat9 configuration file

Put this file in games-roguelike/slashem/files/0.0.7E6 and
games-roguelike/slashem/files/0.0.7E7 directories in the portage tree.
All it does is changing the path to gzip from /usr/bin/gzip to /bin/gzip
Comment 2 Pekka Rousu 2005-08-28 08:58:01 UTC
The proposed patch doesn't seem to have any effect.

Anyway, I thought that saving problem was fixed as bug 98318, but it looks like
I didn't test it good enough. There was still a problem which was result from
Gentoo definition of VAR_PLAYGROUND, which is obsolete define and shouldn't be
used when File Hierarchy Standard (FILE_AREAS) is used. Previously I thought
that this define just had no effect with FILE_AREAS, but now it seems it
actually confuses the game when dealing with savegames. There is another unused
define, LOCKDIR, which should be removed as well. Patch will follow soon which
removes obsolete defines. After applying the patch gentoo-paths.patch should be
removed from files/0.0.7E6. 

Comment 3 Pekka Rousu 2005-08-28 08:59:36 UTC
Created attachment 67085 [details, diff]
Remove obsolete VAR_PLAYGROUND and LOCKDIR defines
Comment 4 Chris Gianelloni (RETIRED) gentoo-dev 2006-10-05 09:12:42 UTC
I'm going to guess that this is still valid with the 0.0.772 ebuild that I just put into portage, correct?
Comment 5 Pekka Rousu 2006-10-05 15:50:52 UTC
Created attachment 98890 [details, diff]
Latest version of my patch

Saving problem is still there. This patch fixes the saving problem for latest version and fixes the qt-support. All "Only in /usr/portage/games-roguelike/slashem/files:" files mentioned in the patch should be removed as obsolete. If you like a separate bug report for the qt-fix, it is easy to remove qt-stuff from this patch.
Comment 6 Chris Gianelloni (RETIRED) gentoo-dev 2006-10-06 09:28:03 UTC
Cool.  Fixed in CVS.