As "Gentoo is not just Linux" ;) The attached patch should be fine replacing the one with the same name in current apache patchset to Gentooify apache information without fixing it to "Linux" for FreeBSD. Thanks, Diego
Created attachment 66632 [details, diff] 00_all_gentoo_base.patch
Created attachment 66949 [details, diff] 00_all_gentoo_base.patch The first patch wasn't so good... "Gentoo/Unix" is a bit... vague :P This one is a bit more hacky but enables support for quite every port we have going on right now :P (NetBSD and DragonFly are not official projects, yet, but we have people working on them, and better fixing this now instead of submitting three patches to improve the stuff :) )
flameeyes: you should also have an #else case for the big #ifdef block (not only #elif's). It's unlikely ever to happen that one of these it not defined .... but believe me that this case will happen :)
I did it this way to make sure that other ports (Solaris? Cygwin?) are needed to edit it to add their own branding. Gentoo/Unknown just seem so wrong, and is going to be ignored as the default is not to display the full data.
Why not just remove the platform completely, and leave it at just "Gentoo" instead of something like "Gentoo/Linux" "Gentoo/FreeBSD" or any one of many others. This makes it easier to maintain.
Because as was already discussed we must refer to Gentoo/Something :)
flameeyes: When? I don't recall that. I just grepped the logs of #gentoo-apache which I have on disk since I became involved with apache on gentoo (over a year ago) and I don't see any indication of such a discussion. Either way, whether it was discussed before or not, now seems like a good time to discuss it again.
That was discussed on -core some weeks ago, Donnie was the one that make us notice that.
We've decided that we are only going to brand Gentoo and not Gentoo/ARCH. Changes made in the svn that our patch tarball is generated from. This change will show up in the next revision or version of apache.
