Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 102813 - wrong netfilter lockhelp.h dependence in l7-filter-1.4
Summary: wrong netfilter lockhelp.h dependence in l7-filter-1.4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Daniel Black (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-17 04:16 UTC by Hod
Modified: 2005-08-19 21:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hod 2005-08-17 04:16:17 UTC
lockhelp.h was removed from kernel tree but l7-filter still has dependence on it.

Reproducible: Always
Steps to Reproduce:
1. install the latest gentoo-sources
2. emerge l7-filter
3. cd /usr/src/linux ; make menuconfig (select -> Device Drivers -> Networking
Support -> Networking Options -> Network Packet Filtering -> Netfilter
Configuration -> Layer 7 match support); make

Actual Results:  
  CC      net/ipv4/netfilter/ipt_layer7.o
  net/ipv4/netfilter/ipt_layer7.c:22:43: linux/netfilter_ipv4/lockhelp.h: No
such file or directory
  net/ipv4/netfilter/ipt_layer7.c:71: warning: type defaults to `int' in
declaration of `DECLARE_RWLOCK'
  net/ipv4/netfilter/ipt_layer7.c:71: warning: parameter names (without types)
in function declaration
  net/ipv4/netfilter/ipt_layer7.c:71: warning: data definition has no type or
storage class
  net/ipv4/netfilter/ipt_layer7.c:72: warning: type defaults to `int' in
declaration of `DECLARE_LOCK'
  net/ipv4/netfilter/ipt_layer7.c:72: warning: parameter names (without types)
in function declaration
  net/ipv4/netfilter/ipt_layer7.c:72: warning: data definition has no type or
storage class
  net/ipv4/netfilter/ipt_layer7.c: In function `match_no_append':
  net/ipv4/netfilter/ipt_layer7.c:241: warning: implicit declaration of function
`WRITE_LOCK'
  net/ipv4/netfilter/ipt_layer7.c:241: error: `ct_lock' undeclared (first use in
this function)
  net/ipv4/netfilter/ipt_layer7.c:241: error: (Each undeclared identifier is
reported only once
  net/ipv4/netfilter/ipt_layer7.c:241: error: for each function it appears in.)
  net/ipv4/netfilter/ipt_layer7.c:260: warning: implicit declaration of function
`WRITE_UNLOCK'
  net/ipv4/netfilter/ipt_layer7.c: In function `match':
  net/ipv4/netfilter/ipt_layer7.c:380: warning: implicit declaration of function
`LOCK_BH'
  net/ipv4/netfilter/ipt_layer7.c:380: error: `list_lock' undeclared (first use
in this function)
  net/ipv4/netfilter/ipt_layer7.c:383: warning: implicit declaration of function
`UNLOCK_BH'
  net/ipv4/netfilter/ipt_layer7.c:386: error: `ct_lock' undeclared (first use in
this function)
  net/ipv4/netfilter/ipt_layer7.c: At top level:
  net/ipv4/netfilter/ipt_layer7.c:457: warning: initialization from incompatible
pointer type
  net/ipv4/netfilter/ipt_layer7.c: In function `layer7_write_proc':
  net/ipv4/netfilter/ipt_layer7.c:507: warning: ignoring return value of
`copy_from_user', declared with attribute warn_unused_result
  make[3]: *** [net/ipv4/netfilter/ipt_layer7.o] error 1
  make[2]: *** [net/ipv4/netfilter] error 2
  make[1]: *** [net/ipv4] error 2
  make: *** [net] error 2
Comment 1 Daniel Black (RETIRED) gentoo-dev 2005-08-17 05:00:00 UTC
I noticed this a few hours ago. The patch on the l7-filter.sf.net home page 
will apply cleanly to the /usr/src/linux directory and will compile 
afterwards. I'll automate this soon. 
Comment 2 Daniel Black (RETIRED) gentoo-dev 2005-08-19 21:36:35 UTC
fixed in reedited 1.4