Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 102775 - media-libs/xine-lib - patch for faad on amd64
Summary: media-libs/xine-lib - patch for faad on amd64
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Diego Elio Pettenò (RETIRED)
URL:
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks:
 
Reported: 2005-08-16 17:38 UTC by Dan Doel
Modified: 2005-09-03 02:46 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch that fixes aac playback on amd64 (xine-faad-amd64.patch,2.77 KB, patch)
2005-08-16 17:41 UTC, Dan Doel
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Doel 2005-08-16 17:38:41 UTC
Due to a flaw in the version of libfaad included in xine-lib (including  
version 1.1.0 which was recently released), xine-based players cannot decode  
aac audio. Since xine-lib seems to be unable to use an external faad library  
(newer versions of the package in portage are fixed with a patch), xine-lib  
itself must be patched to fix the problem.  
  
I've located such a patch, and it works with version 1.1.0. I suspect it also  
works with earlier versions (1.0.1 and 1.0.2), though I haven't tested with  
them. 
 
I'll add the patch as an attachment following the posting of this. 

Reproducible: Always
Steps to Reproduce:
 



I posted this here because it allows gentoo's package to be fixed. I'm pretty 
sure that the xine developers know about the problem (they discussed it on the 
xine-devel mailing list last October), but I'm unsure as to why they haven't 
fixed it yet (especially since it's a relatively trivial problem). I suspect 
that it won't be fixed until they merge in a newer version of faad (assuming 
they ever do; I can't figure out why they didn't do it in 1.1.0).
Comment 1 Dan Doel 2005-08-16 17:41:19 UTC
Created attachment 66112 [details, diff]
Patch that fixes aac playback on amd64

The actual problem seems to be that certain structures are declared in two
places, but uses different sized members. One place uses uint32_t (for
instance), and another place uses unsigned long, which on amd64 is 64 bits. The
patch fixes the declarations so that they're the same in both places.
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-09-02 16:03:23 UTC
I'll take care of this tomorrow, with a few others. 
 
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-09-03 02:46:46 UTC
Applied, thanks.