Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 102767 - Proposed patch to use ppp idle timer activity filter external to pppd
Summary: Proposed patch to use ppp idle timer activity filter external to pppd
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Dialup Developers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-16 16:32 UTC by Alex
Modified: 2005-09-02 15:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
The aformentioned patch (ppp.patch,3.42 KB, patch)
2005-08-16 16:33 UTC, Alex
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex 2005-08-16 16:32:44 UTC
Since I was never able to make a decent active-filter for pppd, I created a
patch to ppp-2.4.2 which allows an external application to send pppd ALRM
signals to wake up an idle timer instead of using an inline filter. This way, I
can write a ULOGD plugin to reset the idle timer.

As I do not consider myself an experienced programmer, I want someone who knows
pppd to look at the patch and tell me if it makes sense.

Reproducible: Always
Steps to Reproduce:




Portage 2.0.51.19 (default-linux/x86/2005.0, gcc-3.3.4, glibc-2.3.4.20040808-r1,
2.6.11-gentoo-r9 i686)
=================================================================
System uname: 2.6.11-gentoo-r9 i686 VIA Samuel 2
Gentoo Base System version 1.4.16
Python:              dev-lang/python-2.3.4 [2.3.4 (#1, Oct 24 2004, 02:42:32)]
distcc 2.16 i386-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
dev-lang/python:     2.3.4
sys-apps/sandbox:    [Not Present]
sys-devel/autoconf:  2.59-r6, 2.13
sys-devel/automake:  1.7.9-r1, 1.8.5-r3, 1.5, 1.4_p6, 1.6.3, 1.9.4
sys-devel/binutils:  2.14.90.0.8-r1
sys-devel/libtool:   1.5.10-r4
virtual/os-headers:  2.4.21-r1
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-O2 -march=c3 -fomit-frame-pointer"
CHOST="i386-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config
/usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -march=c3 -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs autoconfig ccache distlocks sandbox sfperms strict"
GENTOO_MIRRORS="http://gentoo.mirrors.tds.net/gentoo
ftp://ftp6.uni-erlangen.de/pub/mirrors/gentoo
ftp://vlaai.snt.ipv6.utwente.nl/pub/os/linux/gentoo/
http://gentoo.mirrors.tds.net/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 aalib acpi activefilter apache2 apm avi bitmap-fonts cdr cups curl eds
emboss encode foomatic foomaticdb fortran gif gstreamer imagemagick imlib jpeg
libg++ libwww mad mbox mikmod motif mp3 ncurses nls ogg pam perl png python
quicktime readline samba ssl tcpd tiff truetype-fonts type1-fonts vorbis xml2
zlib userland_GNU kernel_linux elibc_glibc"
Unset:  ASFLAGS, CBUILD, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS, PORTDIR_OVERLAY
Comment 1 Alex 2005-08-16 16:33:24 UTC
Created attachment 66107 [details, diff]
The aformentioned patch
Comment 2 Stefan Schweizer (RETIRED) gentoo-dev 2005-08-17 11:15:41 UTC
Did you already send it to the upstream ppp developers?
Comment 3 Alex 2005-08-17 13:37:52 UTC
Yes, but they have bugs quite old in their bug tracking system that are not yet
dispatched/commented on. I thought Gentoo devs might tell me faster if this is a
reasonable solution.
Comment 5 Stefan Briesenick (RETIRED) gentoo-dev 2005-08-17 13:57:18 UTC
patch looks simple and straight-forward. But nonetheless, since this is just a 
nice-to-have extra/new feature and not some kind of bug/security-fix, you 
should really wait for upstream to include it. 
 
the problem with these kind of patches is always, that the installation is 
gentoo-specific after and we have to support it till end of human life. 
 
Comment 6 Alin Năstac (RETIRED) gentoo-dev 2005-09-01 10:54:41 UTC
hmm... I don't see the point.
sure, you could reset idle timers through ALRM signal, but why use such a hairy
solution? the only event needed is transmission/reception of some kind of
packages, which already is handled by active-filters.
I know, active-filters support has been buggy lately (libpcap devs really need
to make up their mind), but I believe ppp-2.4.2-r15 and ppp-2.4.3-r8 really
solve any related problem.
Comment 7 Alex 2005-09-01 21:42:11 UTC
I find active-filter ungodly confusing. Also, since this allows an
iptables-based active filter, you can do far more complex active-filters.
Example, Port Knocking.
Comment 8 Alin Năstac (RETIRED) gentoo-dev 2005-09-01 23:22:21 UTC
c'mon,  who on Earth will use port knocking as active filter?

a) why don't you test your filters using tcpdump before using them?
b) if you really want a easier way of setting active filters, I recommend you to
use diald. I've used in the good old days (when my link was a dialup one) with
excellent results.
Comment 9 Alex 2005-09-02 15:30:30 UTC
a) Port-knocking is just an example. You could also use this to have any number
of UIs ask the user before dialing.
b) I've never found any decent documentation on diald. I've seen example config
scripts, but never a thorough explanation of what each line does, etc.
Comment 10 Alex 2005-09-02 15:32:02 UTC
Anyway, upstream got back to me and said I ought to add hooks to ppp where
necessary and implement the rest as a plugin. I have no idea how to do that, but
it sounds like a good idea.