Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 102417 - sylpheed-claws-1.9.13 misc fixes and improvements
Summary: sylpheed-claws-1.9.13 misc fixes and improvements
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Marius Mauch (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-13 11:47 UTC by TGL
Modified: 2005-08-13 23:34 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
sylpheed-claws-1.9.13--cleanup.patch (sylpheed-claws-1.9.13--cleanup.patch,3.26 KB, patch)
2005-08-13 11:48 UTC, TGL
Details | Diff
sylpheed-claws-1.9.13--icon_and_desktop_installation.patch (sylpheed-claws-1.9.13--icon_and_desktop_installation.patch,1.07 KB, patch)
2005-08-13 17:38 UTC, TGL
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description TGL 2005-08-13 11:47:30 UTC
Hi,

Here is a patch with misc small fixes and improvements for the
Sylpheed-Claws-1.9.13 ebuild:

 - removed anything related to gdk-pixbuf and imlib, since this libs are no more
used (which has the benefit to allow building it on gtk-1.2-free systems)

 - fixed crypto plugins configure options. One (pgpcore) was missing in the
configure options and thus was built or not depending on autoconf-detection
instead of the crypt USE flag, and an other was missnamed (pgpmime-inline is now
pgpinline-plugin)

 - fixed x11-libs/compface only beeing required if USE=xface

 - explicitly disabled mathml plugin (was autoconf-detected before -- the best
would be to have a mathml USE flag, but so far i've not been able to build
gtkmathview, so i can't say whether it works)

 - made explicit in the ebuild that trayicon and startup-notification support
are unconditionnaly built (this is really cosmetic, it's just that i prefer to
know that kind of stuffs while reading the ebuild instead of testing what are
the autoconf defaults)

 - added "doc" USE flag support to enable/disable installation of HTML manual
and FAQ (Help menu will anyway point to the online version if they are not
installed). Also made it honor $LINGUAS instead of installing all languages.

Also, something i've not modified but was wondering about is the "gnome" USE
flag for gnome-print support: there's at least one ebuild (dev-perl/gtk-perl)
which uses a "gnome-print" flag already for that purpose, wouldn't it be better
to do the same?
Comment 1 TGL 2005-08-13 11:48:03 UTC
Created attachment 65868 [details, diff]
sylpheed-claws-1.9.13--cleanup.patch
Comment 2 TGL 2005-08-13 17:38:01 UTC
Created attachment 65886 [details, diff]
sylpheed-claws-1.9.13--icon_and_desktop_installation.patch

Here is a second path, for src_install that time. It changes the following:

 - removed instructions about the .desktop file (it is correctly installed by
the Makefile now, and the sed commands were just corrupting it)

 - as for the .png icon, the Makefile installs one with the correct name in
/usr/share/icons/hicolor/48x48/apps. Removed old instructions, and added
installation of a duplicate in /usr/share/pixmaps since i think some DE still
use this dir, and also added installation of the higher resolution icons.

 - removed the "rm -rf ${D}/usr/share/gnome", since the Makefile no more
creates such directory.
Comment 3 Marius Mauch (RETIRED) gentoo-dev 2005-08-13 23:34:00 UTC
Ok, added most of it, with a few changes though:
- I still got the .desktop file in /usr/share/gnome with a wrong Exec line, so I
only changed that part a little bit
- default to all languages if we don't find a match in LINGUAS
- Kept the mathml plugin as it was, as we don't have the required dep in portage
(and I don't want to add it). 
- made symlinks for the icon instead of copies