The attached patch will add support for an enable-audio switch in the mplayerplug-in configuration files so that users can enable embedded video without opening the door to background music on poorly-designed sites. This not only decreases annoyance, it improves page load times and, merely by statistics, reduces the chance of falling victim to a browser-crashing bug in mplayerplug-in (I've encountered them every now and then). Despite my use of Deer Park alpha 2 to post this, I can vouch for this patch and the reasons behind it when mplayerplug-in is used with Firefox 1.0.x. Reproducible: Always Steps to Reproduce: Go to a site with background music Actual Results: Annoying background music plays after it takes extra time to load mplayerplug-in Expected Results: There should be a simple way for me to disable the playing of audio files so it displays a "plugin required" note after rendering the page quickly.
Created attachment 65749 [details, diff] A working patch to implement support for the enable-audio flag in mplayerplug-in.conf By virtue of the overlay, I'm using this without problem right now. I can also confidently say that, unless the code blocks I duplicated had runtime bugs, this won't have runtime bugs either.
This patch is being rejected upstream by the mplayerplug-in developer (me), as this is the wrong way to do this and will inadvertantly disable media on sites where it is wanted. Probably a better patch would do do this deeper in the code and if the Window is Null or 0 then the play should not start. I will consider a patch that does that.
Alright then, closing as invalid. If there's a new patch, run it by upstream first. Thanks!
