Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 102215 - hald doesn't create entry for floppy in fstab
Summary: hald doesn't create entry for floppy in fstab
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Project Gentopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-12 03:27 UTC by Akos Ladanyi
Modified: 2005-12-29 22:26 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Replacement for hal-0.4.7-sys_floppy_detection.patch (hal-0.4.7-my_sys_floppy_detection.patch,784 bytes, patch)
2005-10-11 05:20 UTC, Christian Becke
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Akos Ladanyi 2005-08-12 03:27:49 UTC
The problem is that while hal creates an entry for my cdrom in fstab, it doesn't
create one for the floppy. But it used to.

I have the following installed:
hal-0.4.7-r2
gentoo-sources-2.6.12-r6

I saw that hal has a patch: hal-0.4.7-sys_floppy_detection.patch, which does the
following:
-       sscanf (device->bus_id, "floppy%d", &number);
+       sscanf (device->bus_id, "%*[flopy.]%d", &number);

I don't know if this is the cause of my problem, but in the second line floppy
is written as flopy (with one p).

Reproducible: Always
Steps to Reproduce:
Comment 1 Doug Goldstein (RETIRED) gentoo-dev 2005-08-18 00:31:09 UTC
I don't have a floppy drive to test. But it does in fact look wrong. Please
update the patch to include the "p" and you can run "emerge --oneshot --digest
hal" and test it.
Comment 2 Akos Ladanyi 2005-08-18 02:05:51 UTC
Just checked the K&R book, and that line does make sense. So the one p is not
the cause of the problem. I guess that patch tries to address some change in the
2.6.12.x kernels, but it fails to do so.
Comment 3 Andrew Stadt 2005-10-10 21:48:33 UTC
(In reply to comment #2)
> Just checked the K&R book, and that line does make sense. So the one p is not
> the cause of the problem. I guess that patch tries to address some change in the
> 2.6.12.x kernels, but it fails to do so.

In theory it should work, though I'm not sure why they put the "%*" in the patch
 as the strcmp just above that line already proves the that device->bus_id MUST
start with 'floppy'.  I think in some kernel version it changed from 'floppy0'
to 'floppy.0' (just don't quote me on that) and that is what I think this patch
is trying to correct for,

In any case, same problem on my end, running hald --daemon=no --verbose=yes
always seems to indicate that its looking for [/sys]/block/fd135085304, which I
beliede should be [/sys]/block/fd0.  In any case, hal does correctly identify
the floppy in that function, so I don't think that the patch messed things up...
 the trouble seems to be somewhere after that function.  My guess is that they
do something similar somewhere else, but this patch only addresses the one
occurrence.

It seems a new version of both dbus & hal have just been added to portage, so
I'll try those out.
Comment 4 Christian Becke 2005-10-11 05:16:31 UTC
Added an updated hal-0.4.7-sys_floppy_detection.patch that adresses both
occurences of the scanf statement in hal-0.4.7/hald/linux/platform_bus_device.c.
Fixes the floppy detection issue on my system.
Comment 5 Christian Becke 2005-10-11 05:20:03 UTC
Created attachment 70358 [details, diff]
Replacement for hal-0.4.7-sys_floppy_detection.patch
Comment 6 Andrew Stadt 2005-10-11 06:21:47 UTC
Works on this end.
Comment 7 Petteri Räty (RETIRED) gentoo-dev 2005-10-31 00:29:53 UTC
Updating fstab is deprecated. In ~arch pmount is already used to mount floppies.
pmount does not need any entries to fstab.

0.9.6
-----
- pmount-hal: support device argument
- pmount manpage: fix default mount options inconsistency
- pmount-hal: full support for HAL expored mount policy (including
  global and per-drive policy, and the "exec" option)
- autotoolized build system, thanks to Aaron Bockover
- pmount: fixed umask parsing, umask 000 works now
- pmount-hal: full support for storage devices to mount floppies and similar
  devices
Comment 8 Michal Kurgan (RETIRED) gentoo-dev 2005-11-07 07:51:16 UTC
Ok i use stable configuration and hal don't update fstab (for usb removables 
in my system, it's another known problem, just as many linux problems..., 
cound You give some link with references about this?)   
pmount in portage can't be used with kde 3.4...   
   
Any idea how i can have simple removable media mounting?   
No mount as root, but with kdemedia-ioslave. Everything was good with udev-058   
but now there is no such version in portage. Why it was removed?   
   
hal-0.4.7-r2  
udev-0.70-r1 
dbus-0.23-r3 
Comment 9 Petteri Räty (RETIRED) gentoo-dev 2005-11-07 08:06:46 UTC
(In reply to comment #8)
> Ok i use stable configuration and hal don't update fstab (for usb removables 
> in my system, it's another known problem, just as many linux problems..., 
> cound You give some link with references about this?)   
> pmount in portage can't be used with kde 3.4...   

It can if you update to ~arch version of kde 3.4 or use an older version from my
personal overlay
http://aria.salaneuvokset.net/ebuilds/sys-apps/pmount/

I have been running a stable kde + my pmount version for mounting on one of the
systems I maintain quite a while now.
Comment 10 Michal Kurgan (RETIRED) gentoo-dev 2005-11-14 14:36:06 UTC
After 2 days of compiling unstable kde 3.4.3 and pmount i say one thing: 
this don't work. No easy usb drive mounting. I can use pmount to mount this 
drive by user from console but no icon in kde media applet or desktop. I tried 
various versions of dbus and hal but many of them make media ioslave unusable 
(it even can't start).  
udev-070-r1  
hal-0.5.4  
dbus-0.50-r1  
pmount-0.9.6  
So still i cant use easy gui mount, as it was some time ago.  
  
Now i try to compile kde 3.5... we will see in 2 days.  
  
  
Comment 11 Doug Goldstein (RETIRED) gentoo-dev 2005-12-29 22:25:54 UTC
While I don't like the fstab updating, I do understand the hesitation of all the ARCH teams to mark newer revisions as stable. Which results in our users using stable having a broken system. So I will commit this patch.

re-emerge your current version. Please try to test 0.4.8 as much as possible.
Comment 12 Doug Goldstein (RETIRED) gentoo-dev 2005-12-29 22:26:09 UTC
I didn't revbump hal for this.