Bug 10216 – patch for evms for 1.2.0 in lolo-sources

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Thomas Raschbacher 2002-11-04 14:32:23 UTC]

hi!

just encountered a bug with evms shutdown code .. it resynced raid(1) stuff
every boot cuz of the error..

this fixes it ..

greetings, LordVan

[Comment 1 Thomas Raschbacher 2002-12-11 17:42:11 UTC]

here's the patch:

--- old/drivers/evms/evms.c     Thu Oct 24 10:38:05 2002
+++ new drivers/evms/evms.c     Thu Oct 24 10:38:34 2002
@@ -3511,7 +3511,7 @@
                         * NOTE: the delete operation will
                         * clear the bits in the flags field.
                         */
-                       dv.command = is_open(i);
+                       dv.command = (is_open(i)) ? 0 : 1;
                        dv.minor = i;
                        dv.status = 0;
                        rc = evms_delete_volume(volume, &dv);
@@ -5444,7 +5444,7 @@
                         * is mounted, and 'hard' delete
                         * if it is not.
                         */
-                       dv.command = is_open(i);
+                       dv.command = (is_open(i)) ? 0 : 1;
                        dv.minor = i;
                        dv.status = 0;
                        evms_delete_volume(volume, &dv);

[Comment 2 corryk 2003-01-09 14:01:29 UTC]

Submitted patch fixes raid1 resync on reboot.

Patch has been accepted into EVMS 1.2.1.

[Comment 3 Brandon Low (RETIRED) 2003-01-09 14:09:57 UTC]

hmm... I'll do one more _rc of lolo-sources with evms-1.2.1, thanks.

[Comment 4 Brandon Low (RETIRED) 2003-01-09 14:13:14 UTC]

wait, what am I talking about I already have 1.2.1 in the latest lolo-sources...
so... wtf are we dealing with here?  Does it work in teh latest or not?

[Comment 5 Thomas Raschbacher 2003-01-11 03:33:52 UTC]

afaik it should be in 1.2.1 ... haven't tried tough ..