Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 10151 - ntl-5.3.ebuild (New Package)
Summary: ntl-5.3.ebuild (New Package)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: George Shapovalov (RETIRED)
URL: http://www.shoup.net/ntl
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-11-03 15:31 UTC by Brendan Johnson
Modified: 2002-11-11 18:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
NTL ebuild (ntl-5.3.ebuild,1.22 KB, text/plain)
2002-11-03 15:34 UTC, Brendan Johnson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Johnson 2002-11-03 15:31:02 UTC
This is a Number Theory Library for C++. Very useful for crypto and research. It
is writen by Victor Shoup ( http://www.shoup.net ) I would suggest it go in
dev-libs/ntl

Attached you should find the ebuild. I built the ebuild to depend on the GMP
library (which is already in the portage tree) to speed up arithmetic. Other
than all NTL needs is the normal compiler/libs. 

I have tested it on Gentoo 1.4-r1 with GCC 3.2 and on Gentoo 1.2 with GCC 2.95
-- eveything worked well.
Comment 1 Brendan Johnson 2002-11-03 15:34:34 UTC
Created attachment 5355 [details]
NTL ebuild
Comment 2 George Shapovalov (RETIRED) gentoo-dev 2002-11-08 02:57:44 UTC
Hi Brendon.

Thank you for your submission!
I have procesed the ebuild. There were a few things I would like to poitn out:

1. please, *please* include full ebuild name in your submission. Version number
is important!

2. SRC_URI should contain ${P} instead of "ntl-5.3" which should have been in
the ebuild name! This way future update may be as easy as just renaming the ebuild!

3. DESCRIPTION is a one-liner. I do appreciate somewhat longer description as
well, but it should have been included in the ChangeLog (which you may include
as well, this would save me some time).

4. your src_unpack does not do any source modification, it may be mitted.

5. !Important! All distribution provided software should be installed in /usr,
not /usr/local. The latter should be left untouched to let sysadmin do some
manual installs as he would see fit (FHS requirements).

6. It's not good to set prefix=${D}/usr during the configure step as various
libs may be linked against that position. Instead ${D} prefix should be passed
during make install step (most of the time this is supported correctly, rarely
some sed'ing or patching may be necessary, tis time this seems to work fine).

I also did some doc clean-ups. Please see the committed version.
The ebuild is committed and keymasked, please test and report.

George
Comment 3 George Shapovalov (RETIRED) gentoo-dev 2002-11-11 18:18:42 UTC
Hi Brendan.

Thanks for testing!
Closing the bug now.

George