Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 101234 - webapp-config-1.11-r1 is broken
Summary: webapp-config-1.11-r1 is broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High blocker (vote)
Assignee: Stuart Herbert (RETIRED)
URL:
Whiteboard:
Keywords:
: 102690 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-08-03 11:26 UTC by Bjarke Istrup Pedersen (RETIRED)
Modified: 2005-11-20 09:59 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bjarke Istrup Pedersen (RETIRED) gentoo-dev 2005-08-03 11:26:52 UTC
With webapp-config-1.11-r1, it looks for the files in the wrong place 
inside /usr/share/webapps.

here is the result from trying it install phpsysinfo:

 *   Creating required directories
 *   Linking in required files
 *     This can take several minutes for larger apps
 *     phpsysinfo-2.3-r2 does not install any files from
 *       /usr/share/webapps/phpsysinfo/2.3-r2/htdocs
 *     phpsysinfo-2.3-r2 does not install any files from
 *       /usr/share/webapps/phpsysinfo/2.3-r2/hostroot
 *   Files and directories installed
 * Install completed - success

For some reason the ebuild installed the files into:
/usr/share/webapps/phpsysinfo/2.3-r2/htdocs-secure/

Not sure where this bug is, but it breaks things really bad.
If this works for any of you, please let me know, and I'll submit 
my /etc/vhosts/webapp-config file, since something has to be broken in there 
then.

Reproducible: Always
Steps to Reproduce:
1. emerge webapp-config-1.11-r1
2. emerge phpsysinfo
3. try installing phpsysinfo
Comment 1 Bjarke Istrup Pedersen (RETIRED) gentoo-dev 2005-08-03 11:33:13 UTC
I suspect this change in webapp-config to be causing it:

--- webapp-config-1.11/config/webapp-config     2005-05-30 19:30:56.000000000 
+0000
+++ webapp-config-1.11-r1/config/webapp-config  2005-07-20 21:06:19.000000000 
+0000
@@ -211,7 +211,11 @@ MY_APPROOT="/usr/share/webapps"
 MY_APPDIR="${MY_APPROOT}/${MY_APPSUFFIX}"
 MY_PERSISTROOT="/var/db/webapps"
 MY_PERSISTDIR="${MY_PERSISTROOT}/${MY_APPSUFFIX}"
-MY_HTDOCSBASE="htdocs"
+if [ "${G_F_SECURE}" = "1" ]; then
+       MY_HTDOCSBASE="${VHOST_HTDOCS_INSECURE}"
+else
+       MY_HTDOCSBASE="${VHOST_HTDOCS_SECURE}"
+fi
 MY_HTDOCSDIR="${MY_APPDIR}/${MY_HTDOCSBASE}"
 G_HTDOCSDIR="${VHOST_ROOT}/${G_HTDOCSBASE:-$MY_HTDOCSBASE}"
 MY_HOSTROOTBASE="hostroot"
Comment 2 Bjarke Istrup Pedersen (RETIRED) gentoo-dev 2005-08-03 11:43:23 UTC
Downgrading to webapp-config-1.11 and re-emerging all webapps makes it work, 
so the bug is introduced in 1.11-r1 .
Comment 3 Renat Lumpau (RETIRED) gentoo-dev 2005-08-03 13:36:42 UTC
Eh, why is this PHP? Stu - all you.
Comment 4 Nathan Sullivan 2005-08-25 04:25:03 UTC
ok...i think this all went over our heads for a while, when it came down to
actually being quite simple...

extract from /etc/vhosts/webapp-config:

if [ "${G_F_SECURE}" = "1" ]; then
        echo "insecure in conf. value - ${G_F_SECURE}.";
        MY_HTDOCSBASE="${VHOST_HTDOCS_INSECURE}"
else
        echo "secure in conf. value - ${G_F_SECURE}.";
        MY_HTDOCSBASE="${VHOST_HTDOCS_SECURE}"
fi

extract from /usr/sbin/webapp-config

# support --secure      
                                
        if [ "$G_F_SECURE" == "1" ]; then
                echo "secure in exec";
                G_HTDOCSBASE="${VHOST_HTDOCS_SECURE}"
        else                    
                echo "insecure in exec";
                G_HTDOCSBASE="${VHOST_HTDOCS_INSECURE}"
        fi

------------------------

output:

nsys-us1-gt ~ # webapp-config -U phpmyadmin 2.6.3_p1 -h www.nightsys.net -d
phpmyadmin
secure in conf. value - .
insecure in exec
secure in conf. value - 0.
secure in conf. value - 0.
 * Upgrading phpmyadmin-2.6.2-r2 to phpmyadmin-2.6.3_p1

now...just think quickly, check the /etc/vhosts/webapp-config source, 2 things:

1. the if condition is explicitly setting G_F_SECURE to 1, should be == instead
of =.
2. the if condition is reversed, its setting to the VHOST_HTDOCS_INSECURE
variable when G_F_SECURE = 1. it should be setting to the VHOST_HTDOCS_SECURE
variable when it is 1, else set it to INSECURE.

the executable is correct, just not the /etc/vhosts/webapp-config config file.

tested, works here.
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2005-08-26 03:09:11 UTC
*** Bug 102690 has been marked as a duplicate of this bug. ***
Comment 6 Ronald Hummelink 2005-08-26 04:57:06 UTC
Please provide more descriptive short desc next time, makes it not neaaarly as
easy to miss out when searching for wether an issue is already reported.

(if it weren't broken, why would you report it....)

Still it may be wise to refer to my dupe for whoever will look at this
attempting fix, as i found some weirdness involving the G_F_SECURE variable used
in the wbeapp-config script.

Thank you :)
Comment 7 Kevin 2005-11-05 07:06:33 UTC
Seems this bug is still present, but Nathan Sullivan wrote words on 2005-08-25
04:25 PDT to the effect of, "tested, works here."

He implies a problem with the config-file and not the executable, but I don't
see a patch or exactly what the fix is.

Should I just, by-hand, alter these settings in the config-file that I'm warned
not to alter by hand:

# ========================================================================
# END OF USER-EDITABLE SETTINGS
# ========================================================================

# ========================================================================
# EDIT THE VARIABLES BELOW THIS LINE AT YOUR OWN RISK
#
# These variables are used by the webapp.eclass component of Portage,
# and by /usr/sbin/webapp-config.
#
# If you break your Gentoo installation by changing these settings, then
# re-emerge the webapps-config package to restore the default values
#
# When webapp-config is upgraded, it may add to and/or change the value of
# variables listed here.  If you do not merge in these changes, you will
# probably find that webapp-config will break in horrible ways.
#
# etc-update is NOT optional ;-)
#
# ========================================================================

I see the assignment error (= versus ==)

I see Nathan commenting that the logic of the G_F_SECURE variable is reversed
(what's that variable for anyway... I'm trying to assign a meaning to the G and
the F...).

Should I just make those changes to the config file regardless of the warning? 
Is that the fix?

It's been awhile since any action was taken on this, so I just thought I'd ask
about it.

Thanks
Comment 8 Kevin 2005-11-05 07:26:12 UTC
Another question:

Are the docs from the man page and the executable up to date?  When comparing
the execution of the binary with the descriptions in the man page, the man page
(both section 5 and 8) for webapp-config seems not quite correct on a couple of
issues (same for webapp-config --help):

for example, from webapp-config --help:

"
    --host <host>
        the hostname to configure this application to serve.  Also affects
        where some files go.  If you get this setting wrong, you may need
        to re-install the application to correct the problem!

        default is <host> = 

        to change the default, change the value of VHOST_HOSTNAME
        in /etc/vhosts/webapp-config

        NOTE:
                if the default value is currently 'localhost', that
                probably means that this computer's /etc/hosts file
                is not correctly configured

"

Is this note saying that emerge webapp-config parses my /etc/hosts file in order
to determine what value to assign to the VHOST_HOSTNAME variable?

My webapp-config file reads in part:

========
VHOST_HOSTNAME="localhost"
========

as installed by emerge webapp-config and etc-update (config file says at the
end: WA_CONF_VERSION=6)

Does that mean my /etc/hosts file is not correctly configured?  I compared it
with man 5 hosts and it looks like the example from the man page:

=========
EXAMPLE
        127.0.0.1       localhost
        192.168.1.10    foo.mydomain.org  foo
        192.168.1.13    bar.mydomain.org  bar
        216.234.231.5   master.debian.org      master
        205.230.163.103 www.opensource.org
=========


And I see this:

tombstone vhosts # webapp-config --show-installed

Fatal error: Nothing installed in /var/www/localhost/htdocs-secure/
Fatal error(s) - aborting

I'm intentionally leaving out the --dir option so as to see what the default is.
 I guess the htdocs-secure is one of the problems resulting from this bug, but
what about "localhost?"  I tried changing my VHOST_HOSTNAME in
/etc/vhosts/webapp-config to "" and get the same result for the show-installed
option.

I'm probably missing something important in my understanding, but thought I'd
ask since I'm here...

Thanks
Comment 9 Stuart Herbert (RETIRED) gentoo-dev 2005-11-20 09:59:00 UTC
Fixed in webapp-config v1.50.

Best regards,
Stu