101223 – mozconfig.eclass changes -Os to -O2

Bug 101223 - mozconfig.eclass changes -Os to -O2

Summary: mozconfig.eclass changes -Os to -O2

Status:	RESOLVED INVALID

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal
Assignee:	Mozilla Gentoo Team

URL:
Whiteboard:
Keywords:

Duplicates (2):	67670 107584 (view as bug list)
Depends on:
Blocks:

Reported:	2005-08-03 09:47 UTC by Rafael Ávila de Espíndola
Modified:	2007-03-06 23:38 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Rafael Ávila de Espíndola 2005-08-03 09:47:54 UTC

mozconfig.eclass tries to fix the -O option, but in doing so it changes -O2 to 
-Os. Since Os is more a less the same as O2, I thin that a god fix would be to 
add 
 
elif is-flag -Os; then 
                mozconfig_annotate "from CFLAGS" --enable-optimize=-Os 
 
just before the else. This way -O2 is the default, -O1 and -O0 are used when 
needed and -Os is used only if it is the CFLAGS.

Comment 1 Jakub Moc (RETIRED) gentoo-dev

2005-12-22 21:29:15 UTC

*** Bug 107584 has been marked as a duplicate of this bug. ***

Comment 2 Jakub Moc (RETIRED) gentoo-dev

2005-12-22 21:32:59 UTC

*** Bug 67670 has been marked as a duplicate of this bug. ***

Comment 3 Kathryn Kulick (RETIRED) gentoo-dev

2006-11-08 19:25:00 UTC

Now using mozcoreconf and mozconfig-2 now which fall back to mozilla defaults <- Per Anarchy

Comment 4 Dave Armstrong 2007-03-06 23:38:38 UTC

(In reply to comment #3)
> Now using mozcoreconf and mozconfig-2 now which fall back to mozilla defaults
> <- Per Anarchy
> 

No, it *doesn't* fall back to Mozilla's defaults.  The official releases are compiled with "-Os".  Ebuild authors need to stop override user-specified parameters, otherwise the utility of portage is reduced.