Bug 100818 – [patch] build failure in oroborus-extras 2.0.13

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Ray Kohler 2005-07-30 08:58:51 UTC]

At least on PPC, oroborus-extras-2.0.13 doesn't compile. deskmenu/src/xmalloc.c
includes error.h without need. This causes the build to fail. This patch fixes it.

--- src/xmalloc.c.orig  2005-07-30 11:22:05.000000000 -0400
+++ src/xmalloc.c       2005-07-30 11:22:11.000000000 -0400
@@ -44,8 +44,6 @@
 # define _(Text) Text
 #endif
 
-#include "error.h"
-
 #ifndef EXIT_FAILURE
 # define EXIT_FAILURE 1
 #endif




Reproducible: Always
Steps to Reproduce:
1. emerge oroborus-extras



Actual Results:  
gcc -DHAVE_CONFIG_H -I. -I. -I.     -O2 -g -O2 -pipe -mcpu=7400 -maltivec
-mabi=altivec -fomit-frame-pointer  `pkg-config gtk+-2.0 --cflags` -c xmalloc.c
xmalloc.c:70: error: conflicting types for 'error'
xmalloc.c:70: note: a parameter list with an ellipsis can't match an empty
parameter name list declaration
/usr/include/error.h:47: error: previous declaration of 'error' was here


Expected Results:  
Compiled deskmenu.

firiesen oroborus-extras # emerge --info
Portage 2.0.51.22-r2 (default-linux/ppc/2005.0, gcc-3.4.4, glibc-2.3.4.20041102
r1, 2.6.12-powerpc ppc)
=================================================================
System uname: 2.6.12-powerpc ppc 7455, altivec supported
Gentoo Base System version 1.6.13
dev-lang/python:     2.3.5
sys-apps/sandbox:    1.2.11
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.5
sys-devel/binutils:  2.15.90.0.3-r5
sys-devel/libtool:   1.5.18-r1
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="ppc ~ppc"
AUTOCLEAN="yes"
CBUILD="powerpc-unknown-linux-gnu"
CFLAGS="-O2 -pipe -mcpu=7400 -maltivec -mabi=altivec -fomit-frame-pointer"
CHOST="powerpc-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config /usr/share
config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
CXXFLAGS="-O2 -pipe -mcpu=7400 -maltivec -mabi=altivec -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig ccache distlocks sandbox sfperms strict userpriv usersandb x"
GENTOO_MIRRORS="http://gentoo.arcticnetwork.ca/ http://distfiles.gentoo.org htt
://www.ibiblio.org/pub/Linux/distributions/gentoo"
LANG="en_US"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.namerica.gentoo.org/gentoo-portage"
USE="ppc X alsa altivec bitmap-fonts bonobo bzip2 cdparanoia cdr cups curl dvd 
sd flac gcj gif gmp gtk gtk2 gtkhtml guile imap imlib java javascript jpeg libw
w mpeg ncurses nls ogg oggvorbis opengl pam pdflib perl png python readline spe
l ssl tcpd theora tiff truetype truetype-fonts type1-fonts unicode vorbis xine 
ml xmms xprint xv zlib userland_GNU kernel_linux elibc_glibc"
Unset:  ASFLAGS, CTARGET, LC_ALL, LDFLAGS, LINGUAS, MAKEOPTS, PORTDIR_OVERLAY

[Comment 1 James Laver 2006-12-30 17:11:32 UTC]

Created attachment 105020 [details]
new ebuild

Also broken on x86, but as expected the patch fixes it. Including a new ebuild for inclusion into the tree so we can cross off another bug.

[Comment 2 James Laver 2006-12-30 17:12:24 UTC]

Created attachment 105021 [details, diff]
The patch itself

Attached the patch as a seperate file so the filename matches the ebuild

[Comment 3 Gustavo Zacarias (RETIRED) 2007-05-31 14:06:12 UTC]

Created attachment 120771 [details]
Verbump with new toys & fixes

Give this new version a spin...

[Comment 4 Lucas Chiesa 2007-05-31 14:25:34 UTC]

(In reply to comment #3)
> Created an attachment (id=120771) [edit]
> Verbump with new toys & fixes
> 
> Give this new version a spin...
> 

Works fine in x86. Thanks!

[Comment 5 Gustavo Zacarias (RETIRED) 2007-07-02 14:22:02 UTC]

InCVS since desktop-wm seems to be missing.