The current ebuild for icewm-1.2.2 has a few sed statements to modify the makefiles to have a more Gentoo-like document structure. It patches Makefile, Makefile.in, and src/Makefile, but it doesn't get src/Makefile.in, which causes the "Help" menu in the IceWM menu to fail. It's a pretty simple patch to fix, which I'll post here.
Created attachment 5279 [details, diff] icewm-docs.patch Here's the patch to the ebuild.
fixed in 1.2.2 and 1.2.3_pre1 :) Thanks.
My emerge doesn't seem to be happy with the patches: >>> Unpacking icewm-1.2.3pre1.tar.gz patching file src/wmclient.h missing header for unified diff at line 3 of patch patching file src/aapm.cc /usr/sbin/ebuild.sh: ssed: command not found /usr/sbin/ebuild.sh: ssed: command not found /usr/sbin/ebuild.sh: ssed: command not found /usr/sbin/ebuild.sh: ssed: command not found >>> Source unpacked. Is that ok???
did you emerge icewm or ebuild icewm merge? if you emerged it, it should have pulled in sys-apps/supersed. if not, please emerge supersed
ok, made the ssed's and the gcc31 and aapm patches into one patch file instead for 1.2.3_pre1. this should fix your issues :)
Strange. I did emerge /usr/portage/x11-wm/icewm/icewm-1.2.3_pre1-r1.ebuild because emerge icewm-1.2.3_pre1-r1 and emerge icewm-1.2.3_pre1 were refused by emerge and "emerge icewm" would emerge 1.2.2-r1 (what's the correct way???). Even more strange: emerge --pretend icewm showed that I need an update to 1.2.2-r1 (I had 1.2.2) However, emerge --pretend world did not show icewm at all (but some other updates pending). Why??? Same sillyness for supersed (which I *have* installed, but according to CONTENTS as sed, not as ssed!): emerge --pretend world doesn't mention it at all, but emerge --pretend supersed says that it needs to be upgraded from 3.58 to 3.58-r2?!? What's going on with emerge??? Now for emerging icewm again: It says >>> Unpacking icewm-1.2.3pre1.tar.gz patching file src/wmclient.h missing header for unified diff at line 3 of patch patching file src/aapm.cc >>> Source unpacked. Better, but still not completely happy. Seems to be really broken: When asking for help, icewm still says "Invalid Path: /usr/share/doc/icewm-1.2.3_pre1-r1/html/icewm-1.2.3_pre1/icewm.html"
Sorry for overwriting your changes, but my entry was so long that I didn't want to loose it. As you can see from my prev entry: * Strange things go on with emerge * It's not just a ssed problem, having ssed doesn't cure the broken help.
When talking about icewm patches and ebuilds: 1.) I wasn't too happy with icewm 1.2.2 due to icewm bugs 608316 and 607267 (logout, shutdown and reboot only work after being issued twice, and shutdown always causes a reboot instead of a shutdown). Both are fixed in 1.2.3. Should 1.2.2 be masked? 2.) I just submitted icewm bug 632529 (a silly one-line change for calling the window menu by key instead of by mouse). Can this be included in the patch?
Ooops, rebooting cured the help - it now works (some sort of - see below). Just restarting icewm from within itself wasn't enough for the change to take effect... The help displays the contents and all chapters, but only the first few lines of each chapter - most chapters are truncated (however, the html files are complete).
klaus attach your patch please and I'll add it to the gentoo.diff as for the other problems -- seems like your world file is broken and as for not seeing 1.2.3_pre1 as the latest : go to http://cvs.gentoo.org and scroll down the mainpage of news items to see the news item about stable and unstable/testing profiles
1.) About the patch: I'm not a developer, never prepared patches up to now. However, here is what I did (compiles and works for me): --- wmmgr.cc 2002-11-02 15:57:47.000000000 +0100 +++ wmmgr.cc.orig 2002-11-02 15:55:07.000000000 +0100 @@ -244,7 +244,7 @@ } else if (IS_WMKEY(k, vm, gKeySysWinPrev)) { if (frame) frame->wmPrevWindow(); } else if (IS_WMKEY(k, vm, gKeySysWinMenu)) { - popupWindowListMenu(); + if (frame) frame->popupSystemMenu(); #ifndef LITE } else if (IS_WMKEY(k, vm, gKeySysDialog)) { if (ctrlAltDelete) ctrlAltDelete->activate(); 2.) Help is found, but the display of the help files is still corrupted. (no idea if this is specific to my box, specific to gentoo, or a general bug). 3.) Unpacking the 1.2.3_pre1-r1 sources still complains about a missing header file when applying patches, even with ssed being installed. 4.) Emerge problem number 1: *Building and installing* a package with "ebuild" *removes* the package from the world file (that's why my icewm was no longer in world, although I was absolutely sure it is). Is this corrent behaviour? 5.) Emerge problem number 2: The manpage says that packages can be given with the version. Hence, e.g. "emerge icewm-1.2.2-r1" is expected to work. However, it causes "there are no masked or unmasked ebuilds to satisfy "icewm-1.2.2-r1"". Doesn't work for any package, any version, no matter if masked or unmasked, no matter if given with or without the package category. Definitely a bug. 6.) Emerge problem number 3: For packages with several independent major versions (e.g. gnome 1.x anmd gnome 2.x), emerge auto-updates only the latest major version: If I have both 1.x and 2.x installed (and the package registered in my world file), the 2.x gets updated by "emerge world" or "emerge package", but the 1.x remains unchanged, even if newer unmasked versions of it exist. Hmmm...
Hm. A few things: 1) Hey, supersed is awesome. No more stupid ".orig" stuff. Nice! And the 1.2.2-r1 build works fine for me. 2) Are we sure that we want to apply patches to packages when the patch will probably make it into the next version of the package? I suppose it's relatively harmless, though . . . 3) Problems with Portage (emerge problems, etc) should really go in their own bug. Klaus, I know that your #6 already exists in Bugzilla somewhere, too. 4) I'm guessing that the "help file corruption" thing is actually an issue with the 1.2.2 release, which'll get fixed later, though I could be wrong about that. The IceWM homepage calls IceWM 1.2.2 "the new unstable release" (http://www.icewm.org), so I'm guessing that these kinds of problems are bound to show up; should these all be in ~x86?
1.) I've no trouble with supersed. However, the supersed ebuilds installed it as "sed" instead of "ssed" in all but the latest versions. Please make the icewm ebuild depend on ebuild versions of supersed which really install "ssed"! (I had supersed on my system, but approx 3-4 months old, still "sed": The depends of icewm were met, so emerge didn't upgrade supersed, but failed because "ssed" was missing...). 2.) As I said, icewm 1.2.2 is broken: Doesn't logout/reboot/shutdown. 1.2.3_pre1-r1 fixes that and runs fine for me, but still generates an error about a missing file when applying patches, even with supersed installed correctly. I didn't install icewm 1.2.2 on purpose: It was autoinstalled by "emerge world", i.e. it was gentoo who considered it *stable*, not me (this is a production machine, I never emerge any masked packages on it except in emergencies). At least for me, 1.2.2 is much worse than 1.2.0 and 1.2.3pre1, I had to decide to either downgrade to 1.2.0 or upgrade to the masked 1.2.3. So, as I already suggested, 1.2.2 should be masked (my emerge world want's to re-install 1.2.2 every day)! 3.) You may drop my patch if you don't want it, it is relatively harmless. However, I doubt it will make it into the next version: I've already reported it by email to the icewm team 3 months ago, and it was ignored. 4.) About the help: I have no way to find out if it is my problem, gentoo's problem, or icewm's problem. If you can make sure that it is icewm's problem, fine, forget that item here. 5.) I'll move the emerge problems into separate messages.
