Bug 100022 – libkudzu fails on ppc

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Lars Weiler (RETIRED) 2005-07-23 05:52:57 UTC]

sys-libs/libkudzu-1.1.62 fails on ppc:

cc -c -O2 -mtune=powerpc -fno-strict-aliasing -pipe -Wall -D_GNU_SOURCE -g -I.
-DVERSION=\"1.1.62\" -fpic -o vio.o vio.c       vio.c: In function `vioProbe':
vio.c:182: error: label at end of compound statement
vio.c:129: warning: unused variable `model'
vio.c:129: warning: unused variable `ptr'
make: *** [vio.o] Error 1

It's a blocker for the upcoming LiveCD.

This is the emerge info in the livecd-stage1 chroot on my build-machine:

Portage 2.0.51.22-r2 (default-linux/ppc/2005.1/ppc, gcc-3.4.4,
glibc-2.3.4.20041102-r1, 2.6.10-gentoo-r6-orophin ppc)
=================================================================
System uname: 2.6.10-gentoo-r6-orophin ppc 
Gentoo Base System version 1.6.12
dev-lang/python:     2.3.5
sys-apps/sandbox:    1.2.11
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.5
sys-devel/binutils:  2.15.90.0.3-r5
sys-devel/libtool:   1.5.18-r1
virtual/os-headers:  2.6.8.1-r4
ACCEPT_KEYWORDS="ppc"
AUTOCLEAN="yes"
CBUILD="powerpc-unknown-linux-gnu"
CFLAGS="-O2 -mtune=powerpc -fno-strict-aliasing -pipe"
CHOST="powerpc-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/lib/mozilla/defaults/pref /usr/share/config
/var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -mtune=powerpc -fno-strict-aliasing -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig distlocks sandbox sfperms strict"
GENTOO_MIRRORS="http://distfiles.gentoo.org
http://distro.ibiblio.org/pub/Linux/distributions/gentoo"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="ppc atm fbcon ipv6 livecd ncurses readline socks5 ssl userland_GNU
kernel_linux elibc_glibc"
Unset:  ASFLAGS, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS, MAKEOPTS, PORTDIR_OVERLAY

[Comment 1 Chris Gianelloni (RETIRED) 2005-07-23 08:34:50 UTC]

Since hwsetup allows for multiple things to satisfy this dependency, I'm lowering the severity.  Also, I don't 
know a *thing* about programming for the PPC or any issue with PPC that would cause this, so I'm 
honestly probably not going to be able to fix this, but I'll see what I can do.

[Comment 2 Sven Wegener 2005-07-31 12:15:35 UTC]

It's a simple gcc 3.4 related fix:

--- vio.c.orig  2005-07-31 19:14:53.832728721 +0000
+++ vio.c       2005-07-31 19:14:56.325379068 +0000
@@ -179,6 +179,7 @@
        }

 vethdone:
+;
     }

     if (probeClass & CLASS_CDROM) {

[Comment 3 Stefan Knoblich (RETIRED) 2005-07-31 12:22:13 UTC]

Created attachment 64805 [details, diff]
possible fix

at the moment untested (going to do that now on an amd64)

[Comment 4 Chris Gianelloni (RETIRED) 2005-08-01 04:25:48 UTC]

It compiles fine on amd64.

It does *not* compile on ppc/ppc64, however.

Pylon: can you test this patch on ppc and report back?

[Comment 5 Daniel Ostrow (RETIRED) 2005-08-02 12:56:44 UTC]

While Sven's patch works on ppc/ppc64 I'd rather use the followin just cuz I'm a
stickler for syntax.

--- vio.c.orig  2005-08-02 12:54:20.000000000 -0700
+++ vio.c       2005-08-02 12:50:28.000000000 -0700
@@ -179,6 +179,7 @@
        }

 vethdone:
+       end = end;
     }

     if (probeClass & CLASS_CDROM) {

[Comment 6 Wormo (RETIRED) 2005-09-01 22:19:20 UTC]

patch fixes compile on ppc, and hwsetup works fine compiled against libkudzu.

[Comment 7 Chris Gianelloni (RETIRED) 2005-09-02 06:38:47 UTC]

Daniel's or Sven's?

[Comment 8 Chris Gianelloni (RETIRED) 2005-09-06 14:50:38 UTC]

Added to cvs and marked ~ppc ~ppc64...