Bugzilla Bug 99632

Marked critical due to loss of critical data -- /etc/make.conf! 
 
mirrorselect -oD causes deletion of /etc/make.conf, after the download stage  
(presumably when it would write to make.conf if -o wasn't set).  /etc/make.conf  
continues to exist during the download step.  
  
I'm not sure if shallow causes the deletion or not, since shallow doesn't work,  
here, due to a NAPT based router filtering the ICMP or whatever that netselect  
uses, so shallow always fails and never returns anything to be written.  I DID,  
however, try it, and it doesn't cause the deletion here.  
  

Reproducible: Always
Steps to Reproduce:
mirrorselect -oD 
Actual Results:  
/etc/make.conf is DELETED! 

Expected Results:  
-o is supposed to be output only.  It shouldn't /touch/ make.conf. 

emerge.info to be attached.

Created an attachment (id=63866) [details]
emerge info output

Fixed in my local version, will be in a bugfix release within a few hours. Good
catch.

By the way, unless there is a second bug at play here, it should have moved your
make.conf to make.conf.backup. The real problem was that forgetting to create
the new make.conf afterwards. You should, therefore, be able to retrieve all
your old settings from /etc/make.conf.backup. If the backup was not made, please
file a bug on that as well.

Thanks.

(In reply to comment #2) 
> [U]nless there is a second bug at play here, it should have moved your 
> make.conf to make.conf.backup. 
 
It was, and I had already caught that, only I thought it was one of my backup 
versions.  =8^) 
 
Anyway, all my make.conf is, is a bunch of "source" lines, including other 
files, which I've splitup in a more manageable way.  
(/etc/portage/make.conf/fs, cflags, features, and similar files.)  I really 
LIKE that feature, having put it to use almost immediately upon seeing it 
mentioned in -dev!  =8^) 
 
So, nothing serious here, at least once I figured out the reason portage 
suddenly wanted to downgrade everything back to stable wasn't due to the 
freshly merged version of portage, but to my screwing with mirrorselect.  I do 
keep backups, tho mine was a bit older than your automated one, and rewriting 
it from scratch wouldn't have been an issue anyway.  I was more concerned about 
others running into the issue that weren't as well equipped to handle it.  
So... glad it's fixed, now. 
 
I'm having some strange net connectivity issues ATM and am not going to attempt 
a sync and source d/l until that's fixed, but will set full CLOSED status once 
I get the new version merged and verify (unless I forget =8^(.  Thanks! 

mirrorselect-1.1.4 verified fixed.  Full-closing as promised.