Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 97141 - net-misc/tor-0.1.0.13 version bump - security issue
Summary: net-misc/tor-0.1.0.13 version bump - security issue
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gustavo Felisberto (RETIRED)
URL: http://tor.eff.org/download.html
Whiteboard:
Keywords:
: 89787 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-06-26 13:58 UTC by Will Wilson
Modified: 2005-08-18 07:18 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
torrc.sample.patch-0.1.0.13 (torrc.sample.patch-0.1.0.13,1.33 KB, patch)
2005-08-05 06:25 UTC, Daniel Webert
Details | Diff
tor-0.1.0.13.ebuild (tor-0.1.0.13.ebuild,1.25 KB, text/plain)
2005-08-05 06:25 UTC, Daniel Webert
Details
corrected tor-0.1.0.13.ebuild (tor-0.1.0.13.ebuild,1.26 KB, text/plain)
2005-08-05 07:54 UTC, Jack Griffin
Details
torrc.sample.patch-0.1.0.14 (newpatch.patch,1.06 KB, patch)
2005-08-08 17:00 UTC, Richard Freeman
Details | Diff
tor-0.1.0.14.ebuild (tor-0.1.0.14.ebuild,1.26 KB, text/plain)
2005-08-08 17:01 UTC, Richard Freeman
Details
/etc/init.d/tor (tor,867 bytes, text/plain)
2005-08-09 10:09 UTC, Daniel Webert
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Will Wilson 2005-06-26 13:58:13 UTC
A new stable version of the net-misc/tor anonymizing software has been released.
There have been some pretty major changes since the previous stable.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Will Wilson 2005-07-10 15:05:23 UTC
Version 0.1.0.11 is out:

http://tor.eff.org/download.html
Comment 2 Matteo Spreafico 2005-08-05 02:06:13 UTC
Tor 0.1.0.13 fixes a CRITICAL bug in the security of our crypto
handshakes. All clients should upgrade IMMEDIATELY.

(We mean it. Really. Also, note that with this release we are abandoning
support for the old Tor 0.0.9.x tree. You should stop using it.)

http://tor.eff.org/download.html

  o Bugfixes on 0.1.0.x:
    - Fix a critical bug in the security of our crypto handshakes.
    - Fix a size_t underflow in smartlist_join_strings2() that made
      it do bad things when you hand it an empty smartlist.
    - Fix Windows installer to ship Tor license (thanks to Aphex for
      pointing out this oversight) and put a link to the doc directory
      in the start menu.
    - Explicitly set no-unaligned-access for sparc: it turns out the
      new gcc's let you compile broken code, but that doesn't make it
      not-broken.
Comment 3 Daniel Webert 2005-08-05 05:54:43 UTC
*** Bug 89787 has been marked as a duplicate of this bug. ***
Comment 4 Daniel Webert 2005-08-05 06:25:54 UTC
Created attachment 65174 [details, diff]
torrc.sample.patch-0.1.0.13

torrc.sample.patch-0.1.0.13
Comment 5 Daniel Webert 2005-08-05 06:25:56 UTC
Created attachment 65175 [details]
tor-0.1.0.13.ebuild

tor-0.1.0.13.ebuild
Comment 6 Jack Griffin 2005-08-05 07:54:52 UTC
Created attachment 65179 [details]
corrected tor-0.1.0.13.ebuild

ebuild based on latest 0.0.9.10 ebuild
added dev-libs/libevent to DEPEND
Comment 7 Daniel Webert 2005-08-05 11:30:46 UTC
Comment on attachment 65175 [details]
tor-0.1.0.13.ebuild

jep - sorry missed that
Comment 8 Richard Freeman gentoo-dev 2005-08-06 07:24:51 UTC
Works on amd64, however to use the default config I had to modify the init.d
script to --chuid tor:tor (previously it did not set the group, and since it
starts as non-root it can't change it on its own).
Comment 9 Daniel Webert 2005-08-06 12:08:57 UTC
if you use the torcc.sample there is no problem - everything runs as tor:tor

have a look in the torrc.sample.patch-0.1.0.13

<snip>
+## Default username and group the server will run as
+User tor
+Group tor
</snip>
Comment 10 Richard Freeman gentoo-dev 2005-08-06 13:53:05 UTC
I did take note of the user and group in torrc, and I am in fact using them.

However, as distributed, tor aborts with:

[err] switch_id(): Error setting GID: Operation not permitted


This is because the init.d script starts tor up with uid tor, but not gid tor. 
Then, when tor starts it attempts to setgid to tor it fails since it is not
running as root (since it was spawned as non-root initially).

It looks like the issue is that tor was not in the tor group in /etc/passwd.  My
guess is that an older ebuild version was the source of this issue.

Probably not a show-stopper, although it might not hurt to specify the gid in
the init script.
Comment 11 Matteo Spreafico 2005-08-08 14:36:54 UTC
Tor 0.1.0.14 fixes the second half of an important bug in the security of
our crypto handshakes. This time for sure. :):) All clients should upgrade.

http://tor.eff.org/download.html

  o Bugfixes on 0.1.0.x:
    - Fix the other half of the bug with crypto handshakes.
    - Fix an assert trigger if you send a 'signal term' via the
      controller when it's listening for 'event info' messages.
Comment 12 Richard Freeman gentoo-dev 2005-08-08 17:00:18 UTC
Created attachment 65490 [details, diff]
torrc.sample.patch-0.1.0.14

Updated patch for 0.1.0.14.
Comment 13 Richard Freeman gentoo-dev 2005-08-08 17:01:13 UTC
Created attachment 65491 [details]
tor-0.1.0.14.ebuild

Version bump - revised to fix patch filename.
Comment 14 Richard Freeman gentoo-dev 2005-08-08 17:06:31 UTC
0.1.0.14 ebuilds work fine on mostly-stable amd64
Comment 15 Pablo 2005-08-09 10:06:18 UTC
It works fine for me (~x86) but there is no /etc/init.d/tor, I think it was
there before.
Comment 16 Daniel Webert 2005-08-09 10:09:06 UTC
Created attachment 65541 [details]
/etc/init.d/tor

it the old one from 0.0.9.x
Comment 17 Sune Kloppenborg Jeppesen (RETIRED) gentoo-dev 2005-08-15 05:53:15 UTC
Handling security issue on bug #102245. 
 
Next time please assign security bugs to security@gentoo.org 
Comment 18 Matteo Spreafico 2005-08-16 09:16:00 UTC
Tor 0.1.0.14 is in portage now.
Comment 19 Gustavo Felisberto (RETIRED) gentoo-dev 2005-08-18 07:18:07 UTC
As noted this is already fixed. Thanks for all the help.