First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 94587
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo Security <security@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Romang <zataz@zataz.net>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:
Flags: Requestee:
 
 
  ()

Filename Description Type Creator Created Size Actions
silcd-tmpfile.diff use O_EXCL patch Tavis Ormandy (RETIRED) 2005-06-20 05:56 0000 499 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 94587 depends on: Show dependency tree
Bug 94587 blocks:

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2005-05-31 00:43 0000 
Hello,

In silcd/silcd.c

258 /* Dump server statistics into a file into /tmp directory */
259 
260 SILC_TASK_CALLBACK(dump_stats)
261 {
262   FILE *fdd;
263   char filename[256];
264   
265   memset(filename, 0, sizeof(filename));
266   snprintf(filename, sizeof(filename) - 1, "/tmp/silcd.%d.stats", getpid());
267   fdd = fopen(filename, "w+");
268   if (!fdd)
269     return;
270     
271 #define STAT_OUTPUT(fmt, stat) fprintf(fdd, fmt "\n", (int)stat);
272 
273   fprintf(fdd, "SILC Server %s Statistics\n\n", silcd->server_name);
274   fprintf(fdd, "Local Stats:\n");

....

silc-server-0.9.21 is masked but silc-toolkit-0.9.12 not.

This code is vulnerable to symlink attack.

Regards.

------- Comment #1 From Romang 2005-06-09 01:06:44 0000 ------- 
what about this bug ?

------- Comment #2 From Thierry Carrez (RETIRED) 2005-06-09 09:35:57 0000 ------- 
It's still an Auditing bug, waiting for Tavis to push it back to
Vulnerabilities :)

------- Comment #3 From Tavis Ormandy (RETIRED) 2005-06-11 09:37:14 0000 ------- 
silc-toolkit package doesnt include the daemon, so it's safe...the silc-server 
does, but the only time that code is exercised is on receiving a SIGUSR1, so 
this is highly unlikely to ever be successfully exploited.

As the server is masked there wont be a glsa for this, but upstream should be 
informed and a patch applied before being unmasked.

------- Comment #4 From Romang 2005-06-11 16:51:31 0000 ------- 
Hello,

I contact upstream.

Regards.

------- Comment #5 From Tavis Ormandy (RETIRED) 2005-06-20 05:56:50 0000 ------- 
Created an attachment (id=61573) [details]
use O_EXCL

something like this will do the trick. tested and working.

------- Comment #6 From Thierry Carrez (RETIRED) 2005-06-24 08:12:30 0000 ------- 
Vendor responded, waiting for fixed version

------- Comment #7 From Thierry Carrez (RETIRED) 2005-07-18 04:45:01 0000 ------- 
Eric, any news of upstream release date ?

------- Comment #8 From Romang 2005-07-25 00:18:17 0000 ------- 
Hello,

No vendor feedback since gentoo advise.

Regards

------- Comment #9 From Thierry Carrez (RETIRED) 2005-07-27 07:06:59 0000 ------- 
Eric: I think you can consider releasing this one, maybe resend them an email
first letting them know when you'll do it ?

------- Comment #10 From Sune Kloppenborg Jeppesen 2005-08-15 09:52:19 0000 ------- 
Any news on this one?

------- Comment #11 From Thierry Carrez (RETIRED) 2005-08-21 08:37:33 0000 ------- 
Eric: let me know what you want to do with this one.

------- Comment #12 From Thierry Carrez (RETIRED) 2005-09-01 05:22:42 0000 ------- 
Public, see URL

------- Comment #13 From Thierry Carrez (RETIRED) 2005-09-07 07:19:05 0000 ------- 
Apparently upstream is in no hurry to fix it.
net-irc: please bump with provided patch.

------- Comment #14 From Sven Wegener 2005-09-08 06:32:09 0000 ------- 
net-im/silc-server has been bumped.

------- Comment #15 From Thierry Carrez (RETIRED) 2005-09-08 06:42:56 0000 ------- 
Many thanks, Sven.
First Last Prev Next    No search results available      Search page      Enter new bug