Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 93293 - ebuild.sh stat_perms call missing quotes
Summary: ebuild.sh stat_perms call missing quotes
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Other
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 108082
  Show dependency tree
 
Reported: 2005-05-19 22:05 UTC by Thomas Matthijs (RETIRED)
Modified: 2005-10-19 07:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Matthijs (RETIRED) gentoo-dev 2005-05-19 22:05:14 UTC
--- portage-2.0.51.22/bin/ebuild.sh     2005-05-15 12:20:58.000000000 +0200
+++ /usr/lib/portage/bin/ebuild.sh      2005-05-19 12:13:56.000000000 +0200
@@ -1075,7 +1075,7 @@
        local count=0
        find "${D}/" -user  portage | while read file; do
                count=$(( $count + 1 ))
-               s=$(stat_perms $file)
+               s=$(stat_perms "$file")
                chown root "$file"
                chmod "$s" "$file"
        done


Also stat_perms has a nice 'die' in it, which triggered when i had the error, but its called in a subshell and portage continued on its merry way
Comment 1 SpanKY gentoo-dev 2005-05-20 17:26:17 UTC
i had the quote bug fixed locally, but i'll leave the 'die in a subshell' issue
to someone else ;p
Comment 2 Jason Stubbs (RETIRED) gentoo-dev 2005-05-24 07:24:55 UTC
Brian, I do believe this is your handiwork. ;) 
Comment 3 Dick Marinus 2005-06-03 11:48:22 UTC
adding those quotes shouldn't have to take THREE weeks right?
Comment 4 SpanKY gentoo-dev 2005-06-03 12:11:18 UTC
if you wish to be a jackass, do it somewhere else

no it didnt take THREE weeks, more like THREE days (or less)
Comment 5 Jason Stubbs (RETIRED) gentoo-dev 2005-07-14 05:48:04 UTC
Fixed on or before 2.0.51.22-r1 
Comment 6 Jason Stubbs (RETIRED) gentoo-dev 2005-07-14 06:58:46 UTC
Looking through the batch of bugs, I'm not sure that some of these are 
actually fixed in stable. Others, the requirements have possibly changed after 
the initial fix was committed. 
 
If you think this bug has been closed incorrectly, please reopen or ask that 
it be reopened. 
Comment 7 Thomas Matthijs (RETIRED) gentoo-dev 2005-10-14 10:13:03 UTC
Its back

Index: ebuild.sh
===================================================================
--- ebuild.sh   (revision 2130)
+++ ebuild.sh   (working copy)
@@ -1150,7 +1150,7 @@
                if [ -L "${file}" ]; then
                        lchown ${PORTAGE_INST_UID} "${file}"
                else
-                       s=$(stat_perms $file)
+                       s=$(stat_perms "$file")
                        if [ -z "${s}" ]; then
                                ewarn "failed stat_perm'ing $file.  User 
intervention during install isn't wise..."
                                continue
@@ -1166,7 +1166,7 @@
        count=0
        find "${D}/" -group portage | while read file; do
                count=$(( $count + 1 ))
-               if [ -L ${file} ]; then
+               if [ -L "${file}" ]; then
                        lchgrp ${PORTAGE_INST_GID} "${file}"
                else
                        s=$(stat_perms "$file")
Comment 8 Jason Stubbs (RETIRED) gentoo-dev 2005-10-19 07:46:22 UTC
Released in 2.0.53_rc6 
Comment 9 Jason Stubbs (RETIRED) gentoo-dev 2005-10-19 07:47:36 UTC
Forgot to mark it..