Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 93174 - app-admin/usermin: openpam and g/fbsd compatibility
Summary: app-admin/usermin: openpam and g/fbsd compatibility
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Jeremy Huddleston (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on: 93118
Blocks: 79024 93119
  Show dependency tree
 
Reported: 2005-05-19 03:29 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2006-04-12 10:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild patch (usermin.patch,2.02 KB, patch)
2005-05-19 03:30 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
usermin.pam-include (usermin.pam-include,245 bytes, text/plain)
2005-05-19 03:30 UTC, Diego Elio Pettenò (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2005-05-19 03:29:31 UTC
The attached patch applied over current ebuild fixes compatibility with openpam and freebsd for usermin:

- the pamd file attached uses include directive instead of pam_stack;
- the newpamd function is used to install the pamd file (note: this require pam eclass as the current newpamd function won't work as pam is not in IUSE and pam support is non-optional);
- sed invocations are corrected to use sed -i -e instead of just -i;
- a find loop is changed into xargs sed to speed it up;
- root:root isn't valid on g/fbsd, so the chown is changed to root:wheel;
- using newinitd to intall init.d file;
- cp -a is a gnuism, changed to use cp -pR should be enough.

Thanks, Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-05-19 03:30:01 UTC
Created attachment 59280 [details, diff]
Ebuild patch
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-05-19 03:30:34 UTC
Created attachment 59281 [details]
usermin.pam-include
Comment 3 Jeremy Huddleston (RETIRED) gentoo-dev 2005-06-19 14:02:16 UTC
Diego, my boxen have been down for the past month, and I'm pretty backlogged on
commits.  I've looked this over and it looks good for me, but I don't like
having root:wheel on linux.  Would root:0 be good for you?

Feel free to make this commit, and thanks.  You may also want to do something
similar to webmin as they're pretty much identical.

--Jeremy

Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-06-19 16:10:12 UTC
Thanks. 
I've changed root:wheel to root:0 so that it uses the right group in both  
OSes. 
 
I'll take a look to webmin also.