Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 927821 - dev-libs/libgit2-1.8.0: fails tests with LTO
Summary: dev-libs/libgit2-1.8.0: fails tests with LTO
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michał Górny
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks: lto 915000
  Show dependency tree
 
Reported: 2024-03-25 15:36 UTC by Sam James
Modified: 2024-04-14 19:05 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,32.52 KB, application/x-xz)
2024-03-25 15:37 UTC, Sam James
Details
LastTest.log.xz (LastTest.log.xz,2.79 KB, application/x-xz)
2024-03-25 15:38 UTC, Sam James
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-25 15:36:52 UTC
I can hit this with GCC 13 too. It needs -O3 -flto.

I have not dug into it much yet, I plan to look more later.

---

  1) Failure:
pack::midx::writer [/var/tmp/portage/dev-libs/libgit2-1.8.0/work/libgit2-1.8.0/tests/libgit2/pack/midx.c:75]
  midx.size != git_str_len(&expected_midx)
  1268 != 47188

  2) Failure:
pack::midx::odb_create [/var/tmp/portage/dev-libs/libgit2-1.8.0/work/libgit2-1.8.0/tests/libgit2/pack/midx.c:100]
  Function call failed: (git_odb_write_multi_pack_index(odb))
  error -1 - invalid multi-pack-index file - chunks extend beyond the trailer

  3) Failure:
pack::sharing::open_two_repos [/var/tmp/portage/dev-libs/libgit2-1.8.0/work/libgit2-1.8.0/tests/libgit2/pack/sharing.c:30]
  2 != pack->refcount.val
  2 != 1



0% tests passed, 1 tests failed out of 1

Total Test time (real) =  55.73 sec

The following tests FAILED:
          1 - offline (Failed)
Errors while running CTest
 * ERROR: dev-libs/libgit2-1.8.0::gentoo failed (test phase):

----

$ emerge --info
Portage 3.0.63_p32_p1711320916 (python 3.12.2-final-0, default/linux/amd64/23.0/hardened, gcc-14, glibc-2.39-r2, 6.6.22 x86_64)
=================================================================
System uname: Linux-6.6.22-x86_64-AMD_Ryzen_9_3950X_16-Core_Processor-with-glibc2.39
KiB Mem:    65758036 total,  17201040 free
KiB Swap:   16662520 total,  16249596 free
Timestamp of repository gentoo: Mon, 25 Mar 2024 15:19:20 +0000
Head commit of repository gentoo: 3947dbed7903a94911a666345437d39898cc473b

Timestamp of repository kde: Mon, 25 Mar 2024 14:49:07 +0000
Head commit of repository kde: 6cc047eec8d738bf7a167062012f0602711a6810

Timestamp of repository qt: Sat, 23 Mar 2024 13:48:18 +0000
Head commit of repository qt: 7d6e43e1727b49ebbedd4a5ce1e9da9dff44eacf

Timestamp of repository sam_c: Sun, 24 Mar 2024 09:48:41 +0000
Head commit of repository sam_c: 186a36744f22732c53828ac05e18fb330a13345b

sh dash 0.5.12
ld GNU ld (Gentoo 9999 p1) 2.42.50.20240324
ccache version 4.9.1 [disabled]
app-misc/pax-utils:        1.3.7::gentoo
app-shells/bash:           5.2_p26::gentoo
dev-build/autoconf:        2.13-r8::gentoo, 2.69-r9::gentoo, 2.72-r1::gentoo
dev-build/automake:        1.16.5-r2::gentoo
dev-build/cmake:           3.29.0::gentoo
dev-build/libtool:         2.4.7-r3::gentoo
dev-build/make:            4.4.1-r1::gentoo
dev-build/meson:           1.4.0-r1::gentoo
dev-java/java-config:      2.3.3-r1::gentoo
dev-lang/perl:             5.38.2-r2::gentoo
dev-lang/python:           3.10.14::gentoo, 3.11.8_p1::gentoo, 3.12.2_p1::gentoo
dev-lang/rust:             1.76.0-r1::gentoo
dev-util/ccache:           4.9.1-r1::gentoo
sys-apps/baselayout:       2.15::gentoo
sys-apps/sandbox:          2.38::gentoo
sys-apps/systemd:          255.4::gentoo
sys-devel/binutils:        2.38-r2::gentoo, 2.39-r5::gentoo, 2.40-r9::gentoo, 2.42-r1::gentoo, 9999::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/clang:           17.0.6::gentoo, 18.1.2::gentoo
sys-devel/gcc:             10.5.0::gentoo, 11.4.1_p20240321::gentoo, 12.3.1_p20240322::gentoo, 13.2.1_p20240323::gentoo, 14.0.9999::gentoo
sys-devel/gcc-config:      2.11::gentoo
sys-devel/lld:             17.0.6::gentoo, 18.1.2::gentoo
sys-devel/llvm:            17.0.6::gentoo, 18.1.2::gentoo
sys-kernel/linux-headers:  6.7::gentoo (virtual/os-headers)
sys-libs/glibc:            2.39-r2::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000
    eclass-overrides: sam_c
    volatile: False
    sync-git-verify-commit-signature: yes
    sync-git-clone-extra-opts: -b stable -c gc.reflogExpire=0 -c gc.reflogExpireUnreachable=0 -c gc.rerereresolved=0 -c gc.rerereunresolved=0 -c gc.pruneExpire=now

crossdev
    location: /var/db/repos/crossdev
    masters: gentoo
    eclass-overrides: sam_c
    volatile: True

kde
    location: /var/db/repos/kde
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/kde.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

local
    location: /var/db/repos/local
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

qt
    location: /var/db/repos/qt
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/qt.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

sam_c
    location: /var/db/repos/sam_c
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/sam_c.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

Installed sets: @sam-emacs, @sam-fonts, @sam-fortune
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O3 -march=native -mtls-dialect=gnu2 -flto=jobserver -fno-semantic-interposition -pipe -fcf-protection=none -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches -Wa,-O2 -Wa,-mtune=znver2  -Wstrict-aliasing -Wreturn-type -Wfree-nonheap-object -Werror=lto-type-mismatch -Werror=strict-aliasing -Werror=odr -Wstrict-aliasing -Wreturn-type -Wfree-nonheap-object -Werror=lto-type-mismatch -Werror=strict-aliasing -Werror=odr -Wbuiltin-declaration-mismatch"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O3 -march=native -mtls-dialect=gnu2 -flto=jobserver -fno-semantic-interposition -pipe -fcf-protection=none -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches -Wa,-O2 -Wa,-mtune=znver2  -Wstrict-aliasing -Wreturn-type -Wfree-nonheap-object -Werror=lto-type-mismatch -Werror=strict-aliasing -Werror=odr"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going --with-bdeps=y --complete-graph --deep --dynamic-deps=n --changed-deps=n --usepkg=y --implicit-system-deps=n --usepkg-exclude sys-fs/zfs --usepkg-exclude sys-fs/zfs-kmod --jobs=4 --load-average 32"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O3 -march=native -mtls-dialect=gnu2 -flto=jobserver -fno-semantic-interposition -pipe -fcf-protection=none -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches -Wa,-O2 -Wa,-mtune=znver2  -Wstrict-aliasing -Wreturn-type -Wfree-nonheap-object -Werror=lto-type-mismatch -Werror=strict-aliasing -Werror=odr"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg clean-logs config-protect-if-modified distlocks fixlafiles ipc-sandbox merge-wait mount-sandbox multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms split-log strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O3 -march=native -mtls-dialect=gnu2 -flto=jobserver -fno-semantic-interposition -pipe -fcf-protection=none -fdiagnostics-color=always -fdiagnostics-urls=never -frecord-gcc-switches -Wa,-O2 -Wa,-mtune=znver2  -Wstrict-aliasing -Wreturn-type -Wfree-nonheap-object -Werror=lto-type-mismatch -Werror=strict-aliasing -Werror=odr"
GENTOO_MIRRORS="https://www.mirrorservice.org/sites/distfiles.gentoo.org/ https://mirror.bytemark.co.uk/gentoo/ https://mirrors.soeasyto.com/distfiles.gentoo.org/"
LANG="en_GB.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,-z,pack-relative-relocs -flto=jobserver -Wl,--defsym=__gentoo_check_ldflags__=0"
LEX="reflex"
LINGUAS="en en_GB"
MAKEOPTS="-j32 --output-sync=line"
PKGDIR="/var/cache/binpkgs"
PORTAGE_BUNZIP2_COMMAND="lbunzip2"
PORTAGE_COMPRESS="xz"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
RUSTFLAGS="-C target-cpu=native -C link-arg=-Wl,-z,pack-relative-relocs"
SHELL="/bin/bash"
USE="X a52 aac acl acpi activities aes alsa amd64 avx avx2 bash-completion bluetooth branding bzip2 cairo caps cdda cdr clang crypt dbus declarative dist-kernel dri dts dvd dvdr editorconfig emacs encode exif f16c filecaps firewalld flac fma3 freetype gdbm gif gmp gpm graphite gtk gui hardened harfbuzz hunspell iconv icu ipv6 jit jpeg kde kdesu kf6compat kwallet lcms libnotify libtirpc lto lzma mad mmx mmxext mng modules-compress mp3 mp4 mpeg multilib ncurses nftables nls ogg opengl openmp pam pango pclmul pcre pdf pgo pic pie pipewire plasma png policykit popcnt ppds pulseaudio qml qt5 rdrand readline screencast sdl seccomp semantic-desktop sha sound spell sse sse2 sse3 sse4_1 sse4_2 sse4a ssl ssp ssse3 startup-notification svg system-av1 system-binutils system-boost system-bootstrap system-cairo system-clang system-digest system-ffmpeg system-harfbuzz system-heimdal system-icu system-jpeg system-leveldb system-libevent system-libs system-libvpx system-libyaml system-llvm system-lz4 system-mitkrb5 system-sqlite system-ssl system-tbb system-uulib system-webp system-zlib systemd test-rust tiff truetype udev udisks unicode upower usb valgrind verify-sig vorbis vulkan wayland widgets x264 xattr xcb xft xml xtpax xv xvid zlib zsh-completion zstd" ABI_X86="32 64" ADA_TARGET="gcc_12" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_anon authn_dbm authn_file authz_dbm authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir env expires ext_filter file_cache filter headers include info log_config logio mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 ntrip navcom oceanserver oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 tsip tripmate tnt ublox" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en en-GB" LCD_DEVICES="bayrad cfontz glk hd44780 lb216 lcdm001 mtxorb text" LLVM_TARGETS="AArch64 AMDGPU ARM AVR BPF Hexagon Lanai MSP430 Mips NVPTX PowerPC RISCV Sparc SystemZ WebAssembly X86 XCore" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-1" POSTGRES_TARGETS="postgres15" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11 pypy3 python3_10 python3_12" QEMU_SOFTMMU_TARGETS="i386 x86_64" QEMU_USER_TARGETS="aarch64 aarch64_be alpha armeb hppa i386 m68k ppc ppc64 ppc64le sparc sparc64 x86_64" RUBY_TARGETS="ruby31 ruby32" VIDEO_CARDS="amdgpu radeonsi radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipp2p iface geoip fuzzy condition tarpit sysrq proto logmark ipmark dhcpmac delude chaos account"
YACC="byacc"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PYTHONPATH, RANLIB, READELF, SIZE, STRINGS, STRIP, YFLAGS
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-25 15:37:27 UTC
Created attachment 888555 [details]
build.log.xz
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-25 15:38:34 UTC
Created attachment 888556 [details]
LastTest.log.xz
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-25 15:42:36 UTC
$ ./libgit2_tests -spack::midx::writer -spack::midx::odb_create -spack::sharing::open_two_repos
Loaded 382 suites:
Started (test status codes: OK='.' FAILURE='F' SKIPPED='S')
FFF

  1) Failure:
pack::midx::writer [/var/tmp/portage/dev-libs/libgit2-1.8.0/work/libgit2-1.8.0/tests/libgit2/pack/midx.c:75]
  midx.size != git_str_len(&expected_midx)
  1268 != 47188

  2) Failure:
pack::midx::odb_create [/var/tmp/portage/dev-libs/libgit2-1.8.0/work/libgit2-1.8.0/tests/libgit2/pack/midx.c:100]
  Function call failed: (git_odb_write_multi_pack_index(odb))
  error -1 - invalid multi-pack-index file - chunks extend beyond the trailer

  3) Failure:
pack::sharing::open_two_repos [/var/tmp/portage/dev-libs/libgit2-1.8.0/work/libgit2-1.8.0/tests/libgit2/pack/sharing.c:30]
  2 != pack->refcount.val
  2 != 3
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-25 15:49:28 UTC
-fno-strict-aliasing works...
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-27 04:02:42 UTC
I finally managed to reproduce it manually, the catch was -DNDEBUG.

(export CFLAGS="-O3 -flto=jobserver"; cmake -DCMAKE_C_FLAGS_RELWITHDEBINFO="" -G Ninja -DBUILD_TESTS=yes -DUSE_SSH=yes -DUSE_GSSAPI=OFF -DUSE_HTTP_PARSER=system -DREGEX_BACKEND=pcre2 -DCMAKE_BUILD_TYPE=RelWithDebInfo -B build; ninja -C build) at 1.8.0 tag
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-27 04:03:07 UTC
(In reply to Sam James from comment #4)
> -fno-strict-aliasing works...

While trying to figure out if it's an aliasing violation, I hit https://gcc.gnu.org/PR114493 :(
Comment 7 Larry the Git Cow gentoo-dev 2024-03-29 04:18:03 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8eee7939509b0575edf7dffc8d09b35e50e05e2b

commit 8eee7939509b0575edf7dffc8d09b35e50e05e2b
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-03-29 04:17:29 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-29 04:17:29 +0000

    dev-libs/libgit2: filter LTO, no SA
    
    Test failures with -O3 -flto. I'm going to keep the bug open for a bit longer
    pending investigation though.
    
    Bug: https://bugs.gentoo.org/927821
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/libgit2/libgit2-1.7.2.ebuild | 3 +++
 dev-libs/libgit2/libgit2-1.8.0.ebuild | 3 +++
 2 files changed, 6 insertions(+)