Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 922729 - sys-devel/binutils, sys-devel/gcc etc. should compress info files and man pages
Summary: sys-devel/binutils, sys-devel/gcc etc. should compress info files and man pages
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-22 23:38 UTC by Alexander Miller
Modified: 2024-02-12 05:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Miller 2024-01-22 23:38:57 UTC
Documentation including info files and man pages should be compressed wrt PORTAGE_COMPRESS settings. The toolchain packages don't do that, as they use non-standard paths for these files due to slotting; other packages with their own (slotted) info or man paths (e.g. llvm) pass them to docompress, and so should binutils and gcc.

As noted, is should be fixed by adding a call to docompress in src_install() for the affected packages. I'm not sure whether these are all relevant packages:
* sys-devel/gcc, sys-devel/kgcc64:
  Add the following line sonwhere in toolchain_src_install() in toolchain.eclass:
        docompress "${DATAPATH}"/{info,man}
* sys-devel/binutils, sys-devel/binutils-hppa64:
  Add exactly the same line to src_install() in the ebuilds
* binutils-apple, sys-devel/gcc-apple:
  These seem to deviate substantially from the normal toolchain packages.
  Haven't looked closely yet, but the docompress args have to change.

Anything else? (I think dev-util/mingw64-toolchain doesn't install documentation.)

I could set up a pull request, but it's probably simpler to fix it youselves:
It's a simple one-liner in each case, but I don't know how you'd like it exactly (E.g. best place to insert the call, which versions are not worth fixing, do you want revbumps,…)
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-23 05:52:21 UTC
We need to do auto{conf,make}{-vanilla,} too (going off INFOPATH on my system).
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-23 05:59:43 UTC
Looking at MANPATH, dev-lang/php, dev-lang/rust, and dev-java/openjdk* need fixing too, but we should do that in a new bug.
Comment 3 Larry the Git Cow gentoo-dev 2024-01-23 06:00:22 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=77808ecbd455e15cd577d1bde0a7b60cc7c63dac

commit 77808ecbd455e15cd577d1bde0a7b60cc7c63dac
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-23 05:57:59 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-23 05:58:15 +0000

    dev-build/automake-vanilla: compress slotted info pages
    
    As noted in the bug, we install to a different location to accommodate slotting
    and hence do not benefit from the automagic compression for /usr/share/doc.
    
    Explicitly opt-in for the info pages we install.
    
    Bug: https://bugs.gentoo.org/922729
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-build/automake-vanilla/automake-vanilla-1.11.6.ebuild | 2 ++
 dev-build/automake-vanilla/automake-vanilla-1.15.1.ebuild | 2 ++
 dev-build/automake-vanilla/automake-vanilla-1.16.5.ebuild | 2 ++
 dev-build/automake-vanilla/automake-vanilla-9999.ebuild   | 2 ++
 4 files changed, 8 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e9f296dbe8aea53425b4bd9a5725f1ffb91d4758

commit e9f296dbe8aea53425b4bd9a5725f1ffb91d4758
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-23 05:56:49 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-23 05:58:14 +0000

    sys-devel/binutils: compress slotted man & info pages
    
    As noted in the bug, we install to a different location to accommodate slotting
    and hence do not benefit from the automagic compression for /usr/share/doc.
    
    Explicitly opt-in for the man & info pages we install.
    
    Bug: https://bugs.gentoo.org/922729
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-devel/binutils/binutils-2.41-r4.ebuild | 2 ++
 sys-devel/binutils/binutils-9999.ebuild    | 2 ++
 2 files changed, 4 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9aa5370643f92645e3f62b59a3d284f9a62a565f

commit 9aa5370643f92645e3f62b59a3d284f9a62a565f
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-23 05:56:09 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-23 05:58:14 +0000

    toolchain-autoconf.eclass: compress slotted info pages
    
    As noted in the bug, we install to a different location to accommodate slotting
    and hence do not benefit from the automagic compression for /usr/share/doc.
    
    Explicitly opt-in for the info pages we install.
    
    Bug: https://bugs.gentoo.org/922729
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/toolchain-autoconf.eclass | 2 ++
 1 file changed, 2 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fd7aa5622003aa9f300fb6b68afcb46ad5f02d00

commit fd7aa5622003aa9f300fb6b68afcb46ad5f02d00
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-23 05:54:52 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-23 05:58:14 +0000

    dev-build/automake: compress slotted info pages
    
    As noted in the bug, we install to a different location to accommodate slotting
    and hence do not benefit from the automagic compression for /usr/share/doc.
    
    Explicitly opt-in for the info pages we install.
    
    Bug: https://bugs.gentoo.org/922729
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-build/automake/automake-1.11.6-r4.ebuild | 2 ++
 dev-build/automake/automake-1.16.5-r1.ebuild | 2 ++
 dev-build/automake/automake-9999.ebuild      | 2 ++
 3 files changed, 6 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=518f49f7400f3b68f7a4a87cf11273fa89daade1

commit 518f49f7400f3b68f7a4a87cf11273fa89daade1
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-23 05:46:54 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-23 05:58:13 +0000

    toolchain.eclass: compress slotted man pages & info pages
    
    As noted in the bug, we install to a different location to accommodate slotting
    and hence do not benefit from the automagic compression for /usr/share/doc.
    
    Explicitly opt-in for the man pages & info pages we install.
    
    Bug: https://bugs.gentoo.org/922729
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/toolchain.eclass | 2 ++
 1 file changed, 2 insertions(+)
Comment 4 Larry the Git Cow gentoo-dev 2024-01-23 06:03:35 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5fc632c772ebd016e08e3632a08349a9d2fbe336

commit 5fc632c772ebd016e08e3632a08349a9d2fbe336
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-23 06:02:22 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-23 06:02:22 +0000

    sys-devel/gcc-apple: compress slotted man pages & info pages
    
    As noted in the bug, we install to a different location to accommodate slotting
    and hence do not benefit from the automagic compression for /usr/share/doc.
    
    Explicitly opt-in for the man pages & info pages we install.
    
    Bug: https://bugs.gentoo.org/922729
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-devel/gcc-apple/gcc-apple-4.2.1_p5666-r3.ebuild | 2 ++
 1 file changed, 2 insertions(+)
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-23 06:03:55 UTC
grobian: I've done the trivial change for gcc-apple which I think should be ok but could you handle binutils-apple?
Comment 6 Larry the Git Cow gentoo-dev 2024-01-27 14:44:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6713edc6636bb84a482cfd0f9bfdad564681b8c5

commit 6713edc6636bb84a482cfd0f9bfdad564681b8c5
Author:     Fabian Groffen <grobian@gentoo.org>
AuthorDate: 2024-01-27 14:43:48 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2024-01-27 14:44:25 +0000

    sys-devel/binutils-apple: compress man pages
    
    Closes: https://bugs.gentoo.org/922729
    Signed-off-by: Fabian Groffen <grobian@gentoo.org>

 sys-devel/binutils-apple/binutils-apple-3.2.6-r1.ebuild   | 2 ++
 sys-devel/binutils-apple/binutils-apple-8.2.1-r103.ebuild | 2 ++
 sys-devel/binutils-apple/binutils-apple-8.2.1-r2.ebuild   | 2 ++
 3 files changed, 6 insertions(+)
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-02-12 05:32:42 UTC
Thanks!