Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 921663 - [guru] app-editors/imhex-1.33.2 adds -Werror flag on its own
Summary: [guru] app-editors/imhex-1.33.2 adds -Werror flag on its own
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gasc Henri
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2024-01-09 13:20 UTC by Agostino Sarubbo
Modified: 2024-04-12 19:59 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,42.81 KB, application/x-xz)
2024-01-09 13:20 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-01-09 13:20:27 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-editors/imhex-1.32.2 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: guru_ci)

NOTE:
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.
Comment 1 Agostino Sarubbo gentoo-dev 2024-01-09 13:20:29 UTC
Created attachment 881770 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Agostino Sarubbo gentoo-dev 2024-03-11 07:43:42 UTC
guru_ci has reproduced this issue with version 1.33.1 - Updating summary.
Comment 3 Agostino Sarubbo gentoo-dev 2024-03-12 07:46:44 UTC
guru_ci has reproduced this issue with version 1.33.1-r1 - Updating summary.
Comment 4 Agostino Sarubbo gentoo-dev 2024-03-18 06:15:32 UTC
guru_ci has reproduced this issue with version 1.33.1-r2 - Updating summary.
Comment 5 Agostino Sarubbo gentoo-dev 2024-04-12 07:51:47 UTC
guru_ci has reproduced this issue with version 1.33.2 - Updating summary.
Comment 6 Larry the Git Cow gentoo-dev 2024-04-12 19:59:12 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=06c7e828b21868e0cd354ded91ec5e568dc868b4

commit 06c7e828b21868e0cd354ded91ec5e568dc868b4
Author:     Henri Gasc <gasc@eurecom.fr>
AuthorDate: 2024-04-12 17:13:59 +0000
Commit:     Henri Gasc <gasc@eurecom.fr>
CommitDate: 2024-04-12 17:17:11 +0000

    app-editors/imhex: Remove Werror, scrub patches
    
    Closes: https://bugs.gentoo.org/921663
    Signed-off-by: Henri Gasc <gasc@eurecom.fr>

 app-editors/imhex/files/remove_Werror.patch        | 24 ++++++++++++++++++++++
 app-editors/imhex/files/remove_dotnet.patch        | 12 +++++------
 ...{imhex-1.33.2.ebuild => imhex-1.33.2-r1.ebuild} |  2 ++
 3 files changed, 32 insertions(+), 6 deletions(-)