Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 911262 - media-libs/ladspa-sdk: Please enable Large File Support (LFS)
Summary: media-libs/ladspa-sdk: Please enable Large File Support (LFS)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lfs-tracker
  Show dependency tree
 
Reported: 2023-07-26 19:27 UTC by Allen Webb
Modified: 2023-07-27 08:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Allen Webb 2023-07-26 19:27:57 UTC
Here is an example QA check failure:
14:21:49.046  * QA Notice: The following files were not built with LFS support:
14:21:49.053  *   Please see https://issuetracker.google.com/201531268 for details.
14:21:49.061  * readdir /usr/bin/listplugins
14:21:49.071  * Full build files:
readdir /build/arm-generic/tmp/portage/media-libs/ladspa-sdk-1.17-r1/work/ladspa_sdk_1.17-.arm/src/search.o
readdir /build/arm-generic/tmp/portage/media-libs/ladspa-sdk-1.17-r1/work/ladspa_sdk_1.17-.arm/bin/listplugins

Neither off_t or struct dirent is exposed in a way that would lead to API breakage by setting the flags. I was able to work around the issue with the following patch:

diff --git a/media-libs/ladspa-sdk/ladspa-sdk-1.17-r1.ebuild b/media-libs/ladspa-sdk/ladspa-sdk-1.17-r1.ebuild
index 8a74c1b22..24081c1e3 100644
--- a/media-libs/ladspa-sdk/ladspa-sdk-1.17-r1.ebuild
+++ b/media-libs/ladspa-sdk/ladspa-sdk-1.17-r1.ebuild
@@ -3,7 +3,7 @@
 
 EAPI=7
 
-inherit toolchain-funcs portability multilib-minimal
+inherit flag-o-matic toolchain-funcs portability multilib-minimal
 
 MY_PN=${PN/-/_}
 MY_P=${MY_PN}_${PV}
@@ -42,6 +42,10 @@ multilib_src_compile() {
                targets
 }
 
+multilib_src_configure() {
+       append-lfs-flags
+}
+
 multilib_src_test() {
        cd src
        emake test
Comment 1 Larry the Git Cow gentoo-dev 2023-07-27 08:20:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=eff07f5a525f6e0e18ddfe72aba9790455e6067d

commit eff07f5a525f6e0e18ddfe72aba9790455e6067d
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-07-27 07:38:14 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-07-27 08:19:32 +0000

    media-libs/ladspa-sdk: build with LFS
    
    Closes: https://bugs.gentoo.org/911262
    Thanks-to: Allen Webb <allenwebb@google.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 media-libs/ladspa-sdk/ladspa-sdk-1.17-r2.ebuild | 65 +++++++++++++++++++++++++
 1 file changed, 65 insertions(+)