Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 910700 - sys-apps/less-633-r2 changes syntax highlighting default without notice
Summary: sys-apps/less-633-r2 changes syntax highlighting default without notice
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-22 22:37 UTC by rnddim
Modified: 2024-02-27 19:36 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description rnddim 2023-07-22 22:37:23 UTC
After updating less recently, I noticed that it suddenly started syntax highlighting certain files I would open. Sometimes this is nice, but I've found it can misidentify files, and pygmentize sometimes makes really unreadable color choices, but I couldn't easily figure out how to disable it.

After quite a bit of searching, I eventually learned about lesspipe, and discovered that a change to the default value of LESSCOLOR appears to be the main difference between this and less-633. I *think* turning this off would be enough to get back the old behavior, but I'm not too sure on that.

This bug report is specifically about the fact that this seems like a big change to make to the functionality of less without any warning. I would prefer the old default of "no syntax highlighting" to be restored (arguing that the "bug workaround", after being around for 16 years, has established itself as the normal behavior), but as long as it's easy to change it's not that big of a deal.

At the very least I would suggest an elog message informing users of the new feature, and how to revert to the old behavior. The lack of documentation anywhere was the one thing that truly bothered me about this issue.

Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-08-12 22:11:03 UTC
Fair point, and I apologise for not considering that.
Comment 2 Larry the Git Cow gentoo-dev 2023-08-13 03:05:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d6404dafdf171eec9933510a160a4506776127e9

commit d6404dafdf171eec9933510a160a4506776127e9
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-08-13 02:56:17 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-08-13 03:01:02 +0000

    sys-apps/less: add 643
    
    Closes: https://bugs.gentoo.org/910700
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/less/Manifest                             |  1 +
 .../less/files/less-643-lesstest-pkg-config.patch  | 34 ++++++++
 sys-apps/less/less-643.ebuild                      | 93 ++++++++++++++++++++++
 sys-apps/less/less-9999.ebuild                     | 46 ++++++-----
 4 files changed, 156 insertions(+), 18 deletions(-)