Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 905269 - games-puzzle/pingus-0.7.6-r5 calls ar directly
Summary: games-puzzle/pingus-0.7.6-r5 calls ar directly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: tc-directly
  Show dependency tree
 
Reported: 2023-04-29 05:59 UTC by Agostino Sarubbo
Modified: 2023-04-29 13:44 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,154.56 KB, text/plain)
2023-04-29 05:59 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-04-29 05:59:50 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-puzzle/pingus-0.7.6-r5 calls ar directly.
Discovered on: amd64 (internal ref: ci)

NOTE:
As per QA policy, toolchain tools must not be called directly because they can cause issue in cross-compiling and because is not possible use a different AR implementation (like llvm-ar). To reproduce, please use sys-devel/gcc-config[-native-symlinks], sys-devel/binutils-config[-native-symlinks].
Comment 1 Agostino Sarubbo gentoo-dev 2023-04-29 05:59:52 UTC
Created attachment 860898 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2023-04-29 05:59:54 UTC
Error(s) that match a know pattern:


sh: line 1: ar: command not found
Comment 3 Ionen Wolkens gentoo-dev 2023-04-29 08:16:22 UTC
wrt the fix in bug #782394, this needs modifying either scons itself or the SConstruct similarly to what I do with godot in its scons patches or else AR="$(tc-getAR)" is not recognized.

Had a look at the AR bug before but I didn't bother given pingus switched build system (but have yet to make a release with that, and doing a snapshot is a bit messy -- unsure if the state has improved since I last looked at it), plus is a low priority bug for a game -- but cool if someone wants to fix it still.
Comment 4 Pacho Ramos gentoo-dev 2023-04-29 13:38:38 UTC
Yesterday I looked and it seemed in a similar state upstream to me :/

I only noticed that NixOS relied on a snapshot from 2019
https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/games/pingus/default.nix
Comment 5 Larry the Git Cow gentoo-dev 2023-04-29 13:44:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=99bee84b101e6d42fb4f76019421edf344c315c6

commit 99bee84b101e6d42fb4f76019421edf344c315c6
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2023-04-29 13:44:07 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2023-04-29 13:44:07 +0000

    games-puzzle/pingus: Fix AR detection
    
    Thanks-to: Ionen Wolkens
    Thanks-to: Agostino Sarubbo
    Closes: https://bugs.gentoo.org/905269
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 games-puzzle/pingus/files/pingus-0.7.6-ar-detection.patch | 10 ++++++++++
 games-puzzle/pingus/pingus-0.7.6-r5.ebuild                |  1 +
 2 files changed, 11 insertions(+)