Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 903984 - app-crypt/yubihsm-shell-2.4.0 adds -Werror flag on its own
Summary: app-crypt/yubihsm-shell-2.4.0 adds -Werror flag on its own
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jason A. Donenfeld
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2023-04-07 15:07 UTC by Agostino Sarubbo
Modified: 2023-04-07 18:16 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,196.78 KB, text/plain)
2023-04-07 15:07 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-04-07 15:07:48 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-crypt/yubihsm-shell-2.4.0 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: ci)

NOTE:
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.
Comment 1 Agostino Sarubbo gentoo-dev 2023-04-07 15:07:50 UTC
Created attachment 859683 [details]
build.log

build log and emerge --info
Comment 2 Larry the Git Cow gentoo-dev 2023-04-07 18:16:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0cb75896d9acfea6936248b325e2c37914e92383

commit 0cb75896d9acfea6936248b325e2c37914e92383
Author:     Jason A. Donenfeld <zx2c4@gentoo.org>
AuthorDate: 2023-04-07 18:15:19 +0000
Commit:     Jason A. Donenfeld <zx2c4@gentoo.org>
CommitDate: 2023-04-07 18:16:30 +0000

    app-crypt/yubihsm-shell: do not run hw-dependent tests and sanitize cflags
    
    Closes: https://bugs.gentoo.org/903983
    Closes: https://bugs.gentoo.org/903984
    Signed-off-by: Jason A. Donenfeld <zx2c4@gentoo.org>

 ...-shell-2.4.0-remove-hardcoded-compiler-opts.patch | 20 ++++++++++++++++++++
 app-crypt/yubihsm-shell/yubihsm-shell-2.4.0.ebuild   |  2 ++
 2 files changed, 22 insertions(+)