Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 902461 - sys-devel/autoconf, sys-devel/automake: installs broken info pages
Summary: sys-devel/autoconf, sys-devel/automake: installs broken info pages
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-03-20 19:08 UTC by Arsen Arsenović
Modified: 2024-01-16 07:20 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arsen Arsenović gentoo-dev 2023-03-20 19:08:40 UTC
Currently, toolchain-autoconf_src_install calls slot_info_pages, which in turn, breaks info pages.  A similar thing happens in Automake, to a smaller extent.

By inserting new data into the info pages the tag table of the document now goes out of date and progressively starts to skew further and further from correct as the document goes on.

IMO, this entire slotting mechanism only causes trouble, even if this particular bug was fixed, by breaking xrefs.  Could we move to using INFO_PATH to slot this?

.. that would also in turn fix the `info autoconf' invocations, which currently go to the autoconf invocation page.

This, of course, obscures older versions of the pages, but I think that's okay for two reasons:

1. We already don't have the older verisons of Automake (but should keep slotting logic, it really helps with GCC work :), and
2. There's precedent, as even GCC does this, and older pages can be opened explicitly if need be.

What do you think?

P.S: I had initially written to bug-texinfo@gnu.org about this, presuming that the pages are valid since Emacs could open them.  Here's the thread: https://lists.gnu.org/archive/html/bug-texinfo/2023-03/msg00053.html
I also asked for opinions on slotting there.
Comment 1 Larry the Git Cow gentoo-dev 2023-03-27 20:40:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d685a4e4ed92516f535b64cf7fe9f599e6ddf8aa

commit d685a4e4ed92516f535b64cf7fe9f599e6ddf8aa
Author:     Arsen Arsenović <arsen@gentoo.org>
AuthorDate: 2023-03-26 12:29:11 +0000
Commit:     Arsen Arsenović <arsen@gentoo.org>
CommitDate: 2023-03-27 20:36:54 +0000

    sys-devel/automake: Fix installing broken Info pages
    
    This commit replaces the Info page slotting mechanism with simple
    INFOPATH setting.
    
    Closes: https://bugs.gentoo.org/902461
    Closes: https://github.com/gentoo/gentoo/pull/30355
    Signed-off-by: Arsen Arsenović <arsen@gentoo.org>

 sys-devel/automake/automake-1.11.6-r4.ebuild |  84 +++++++++++++++++++
 sys-devel/automake/automake-1.16.5-r1.ebuild | 119 +++++++++++++++++++++++++++
 sys-devel/automake/automake-9999.ebuild      |  48 ++++-------
 3 files changed, 220 insertions(+), 31 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8a1b8b22c71b9c3ce843bd0dc768bc71fec30806

commit 8a1b8b22c71b9c3ce843bd0dc768bc71fec30806
Author:     Arsen Arsenović <arsen@gentoo.org>
AuthorDate: 2023-03-26 08:46:51 +0000
Commit:     Arsen Arsenović <arsen@gentoo.org>
CommitDate: 2023-03-27 20:27:12 +0000

    sys-devel/autoconf: Add revisions without Info path breaking
    
    Closes: https://bugs.gentoo.org/902461
    Signed-off-by: Arsen Arsenović <arsen@gentoo.org>

 sys-devel/autoconf/autoconf-2.13-r8.ebuild         | 59 +++++++++++++++
 sys-devel/autoconf/autoconf-2.69-r9.ebuild         | 63 ++++++++++++++++
 sys-devel/autoconf/autoconf-2.71-r6.ebuild         | 88 ++++++++++++++++++++++
 ...oconf-2.72c.ebuild => autoconf-2.72c-r1.ebuild} |  0
 4 files changed, 210 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d59b0c3b126f02ccaa86233e5c28c50a230875b6

commit d59b0c3b126f02ccaa86233e5c28c50a230875b6
Author:     Arsen Arsenović <arsen@gentoo.org>
AuthorDate: 2023-03-26 08:45:28 +0000
Commit:     Arsen Arsenović <arsen@gentoo.org>
CommitDate: 2023-03-27 20:27:11 +0000

    sys-devel/autoconf: Set TC_AUTOCONF_BREAK_INFOS=yes to prevent changes
    
    Recently, the toolchain-autoconf class was edited not to naively slot
    Info pages, breaking them in the process.  To prevent existing revisions
    from changing contents, TC_AUTOCONF_BREAK_INFOS was added to permit
    using old behavior currently.
    
    Closes: https://bugs.gentoo.org/902461
    Signed-off-by: Arsen Arsenović <arsen@gentoo.org>

 sys-devel/autoconf/autoconf-2.13-r2.ebuild | 4 +++-
 sys-devel/autoconf/autoconf-2.13-r7.ebuild | 4 +++-
 sys-devel/autoconf/autoconf-2.69-r5.ebuild | 4 +++-
 sys-devel/autoconf/autoconf-2.69-r8.ebuild | 4 +++-
 sys-devel/autoconf/autoconf-2.71-r1.ebuild | 4 +++-
 sys-devel/autoconf/autoconf-2.71-r5.ebuild | 4 +++-
 6 files changed, 18 insertions(+), 6 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8839833a322cc2776225c20de422b38540a5d27f

commit 8839833a322cc2776225c20de422b38540a5d27f
Author:     Arsen Arsenović <arsen@gentoo.org>
AuthorDate: 2023-03-26 08:40:17 +0000
Commit:     Arsen Arsenović <arsen@gentoo.org>
CommitDate: 2023-03-27 20:27:11 +0000

    toolchain-autoconf.eclass: Add option to disable Info slotting
    
    Closes: https://bugs.gentoo.org/902461
    Signed-off-by: Arsen Arsenović <arsen@gentoo.org>

 eclass/toolchain-autoconf.eclass | 46 +++++++++++++++++++++++++++++++++++++---
 1 file changed, 43 insertions(+), 3 deletions(-)