Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 899744 - net-libs/xdp-tools-1.3.1-r1 adds -Werror flag on its own
Summary: net-libs/xdp-tools-1.3.1-r1 adds -Werror flag on its own
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jason A. Donenfeld
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2023-03-06 07:58 UTC by Agostino Sarubbo
Modified: 2023-03-10 12:07 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,111.12 KB, text/plain)
2023-03-06 07:58 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-03-06 07:58:50 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-libs/xdp-tools-1.3.1 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: ci)

NOTE:
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.
Comment 1 Agostino Sarubbo gentoo-dev 2023-03-06 07:58:53 UTC
Created attachment 856230 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2023-03-07 08:08:00 UTC
ci has reproduced this issue with version 1.3.1-r1 - Updating summary.
Comment 3 Larry the Git Cow gentoo-dev 2023-03-10 12:06:53 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=80fffaf8a1d422cbbb5d0984bc693128f8256a49

commit 80fffaf8a1d422cbbb5d0984bc693128f8256a49
Author:     Holger Hoffstätte <holger@applied-asynchrony.com>
AuthorDate: 2023-03-08 22:12:29 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-03-10 12:06:23 +0000

    net-libs/xdp-tools: various build improvements
    
    - disable LTO
    - remove -Werror from Makefiles
    - fix xdpdump build error with clang
    - add hint about mounting bpffs
    
    Bug: https://bugs.gentoo.org/861587
    Bug: https://bugs.gentoo.org/880919
    Bug: https://bugs.gentoo.org/899744
    
    Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
    Closes: https://github.com/gentoo/gentoo/pull/30005
    Signed-off-by: Sam James <sam@gentoo.org>

 net-libs/xdp-tools/files/1.3.1-no-Werror.patch     | 97 ++++++++++++++++++++++
 net-libs/xdp-tools/files/1.3.1-xdpdump-clang.patch | 36 ++++++++
 ...s-1.3.1-r1.ebuild => xdp-tools-1.3.1-r2.ebuild} | 25 ++++++
 3 files changed, 158 insertions(+)