Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 895066 - dev-libs/igraph-0.10.4 adds -Werror flag on its own (MUSL-CLANG-SYSTEM)
Summary: dev-libs/igraph-0.10.4 adds -Werror flag on its own (MUSL-CLANG-SYSTEM)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Science Biology related packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2023-02-17 08:57 UTC by Agostino Sarubbo
Modified: 2024-05-09 20:43 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,440.15 KB, text/plain)
2023-02-17 08:57 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-02-17 08:57:48 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/igraph-0.10.4 adds -Werror flag on its own (MUSL-CLANG-SYSTEM).
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
(MUSL-CLANG-SYSTEM) in the summary means that bug was found on a machine that runs MUSL libc + clang16 but this bug MAY or MAY NOT BE related to musl/clang16.
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.
Comment 1 Agostino Sarubbo gentoo-dev 2023-02-17 08:57:50 UTC
Created attachment 851980 [details]
build.log

build log and emerge --info
Comment 2 Szabolcs Horvát 2023-02-24 14:47:19 UTC
This can be disabled by passing -DIGRAPH_WARNINGS_AS_ERRORS=OFF. You will find detailed documentation aimed at packagers here: https://igraph.org/c/html/latest/igraph-Installation.html

That said, if you encounter an actual breakage related to this flag (e.g. a new compiler version issuing a new warning), please do report this at https://github.com/igraph/igraph/issues (after checking that it's not already fixed in the latest released version). We do test with new GCC and Clang releases.
Comment 3 Larry the Git Cow gentoo-dev 2024-05-09 20:43:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c5e3d8c14837d19aa08af77f6d22a36cfea701e5

commit c5e3d8c14837d19aa08af77f6d22a36cfea701e5
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-05-09 20:37:45 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-09 20:37:45 +0000

    dev-libs/igraph: disable -Werror
    
    By policy in Gentoo, we don't build with -Werror.
    
    Closes: https://bugs.gentoo.org/895066
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/igraph/igraph-0.10.10.ebuild   | 1 +
 dev-libs/igraph/igraph-0.10.11.ebuild   | 1 +
 dev-libs/igraph/igraph-0.10.4-r1.ebuild | 1 +
 3 files changed, 3 insertions(+)