Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 895014 - sci-electronics/kicad-7.0.0-r1 adds -Werror flag on its own
Summary: sci-electronics/kicad-7.0.0-r1 adds -Werror flag on its own
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Zoltan Puskas
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2023-02-17 07:46 UTC by Agostino Sarubbo
Modified: 2023-02-21 17:56 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,81.38 KB, application/x-xz)
2023-02-17 07:47 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-02-17 07:46:59 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-electronics/kicad-7.0.0 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: ci)

NOTE:
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.
Comment 1 Agostino Sarubbo gentoo-dev 2023-02-17 07:47:02 UTC
Created attachment 851926 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Agostino Sarubbo gentoo-dev 2023-02-18 13:54:47 UTC
ci has reproduced this issue with version 7.0.0-r1 - Updating summary.
Comment 3 Larry the Git Cow gentoo-dev 2023-02-21 17:56:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=996b5c04c7f5fb478244ff8372db0af3eaa130bd

commit 996b5c04c7f5fb478244ff8372db0af3eaa130bd
Author:     Matthew Smith <matthew@gentoo.org>
AuthorDate: 2023-02-20 18:33:52 +0000
Commit:     Matthew Smith <matthew@gentoo.org>
CommitDate: 2023-02-21 17:56:24 +0000

    sci-electronics/kicad: remove -Werror
    
    Closes: https://bugs.gentoo.org/895014
    Acked-by: Zoltan Puskas <zoltan@sinustrom.info>
    Signed-off-by: Matthew Smith <matthew@gentoo.org>

 .../kicad/files/kicad-7.0.0-werror.patch            | 21 +++++++++++++++++++++
 sci-electronics/kicad/kicad-7.0.0-r1.ebuild         |  2 ++
 2 files changed, 23 insertions(+)