Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 890278 - net-fs/cifs-utils-7.0 warning: _FORTIFY_SOURCE redefined with gcc12 hardened _F_S=3
Summary: net-fs/cifs-utils-7.0 warning: _FORTIFY_SOURCE redefined with gcc12 hardened ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's SAMBA Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 847148
  Show dependency tree
 
Reported: 2023-01-09 08:53 UTC by genBTC
Modified: 2023-10-04 17:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
cifs-util build.log (cifs,32.12 KB, application/octet-stream)
2023-01-09 08:54 UTC, genBTC 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description genBTC 2023-01-09 08:53:50 UTC 
When using gentoo-hardened with the new  fortify-source-3.patch  built into Gcc-12.2.1_p20221231 ,
net-fs/cifs-utils package results in a warning about a definition redefined collision.

<command-line>: warning: "_FORTIFY_SOURCE" redefined
<built-in>: note: this is the location of the previous definition

Meaning the package has _F_S=2 hardcoded internally:
 @ Makefile.am / Makefile.in / Makefile  (all)
that flag should be stripped so _F_S=3 can take effect without conflict.



Reproducible: Always
Comment 1 genBTC 2023-01-09 08:54:12 UTC 
Created attachment 848008 [details]
cifs-util build.log

warning: "_FORTIFY_SOURCE" redefined
Comment 2 Agostino Sarubbo gentoo-dev 2023-02-07 14:15:01 UTC 
hardened_tinderbox has reproduced this issue with version 7.0 - Updating summary.
Comment 3 Larry the Git Cow gentoo-dev 2023-10-04 17:01:25 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=79853c374d5f3e0cf1a73a17fec44912739b7012

commit 79853c374d5f3e0cf1a73a17fec44912739b7012
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-10-04 16:58:25 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-10-04 16:58:25 +0000

    net-fs/cifs-utils: don't redefine _FORTIFY_SOURCE
    
    Closes: https://bugs.gentoo.org/890278
    Signed-off-by: Sam James <sam@gentoo.org>

 net-fs/cifs-utils/cifs-utils-7.0-r1.ebuild         | 143 +++++++++++++++++++++
 .../cifs-utils-7.0-no-clobber-fortify-source.patch |  11 ++
 2 files changed, 154 insertions(+)