Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 890014 - [guru] dev-cpp/dpp-10.0.22 overwrites CFLAGS/CXXFLAGS or adds uncommon ones
Summary: [guru] dev-cpp/dpp-10.0.22 overwrites CFLAGS/CXXFLAGS or adds uncommon ones
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Adrian Schollmeyer
URL: https://github.com/brainboxdotcc/DPP/...
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2023-01-07 08:06 UTC by Agostino Sarubbo
Modified: 2023-02-23 09:24 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,183.23 KB, text/plain)
2023-01-07 08:07 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-01-07 08:06:58 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-cpp/dpp-10.0.22 overwrites CFLAGS/CXXFLAGS or adds uncommon ones.
Discovered on: amd64 (internal ref: guru_ci)

NOTE:
This QA check is tinderbox-only, there is the list of the flags that should be dropped out, if you think it is a false positive please let me know..
Comment 1 Agostino Sarubbo gentoo-dev 2023-01-07 08:07:01 UTC
Created attachment 847760 [details]
build.log

build log and emerge --info
Comment 2 Adrian Schollmeyer 2023-01-08 13:03:25 UTC
Upstream sets the flags manually in library/CMakeLists.txt. We should probably try to make this optional upstream or patch the CMakeLists.txt to get rid of the manually set flags. CMake should normally set those flags on an as-needed basis anyway depending on the selected build target.
Comment 3 Adrian Schollmeyer 2023-01-21 20:05:19 UTC
Upstream merged the PR. I assume that a release might follow soon. Otherwise we should be able to backport the PR to the current versions.
Comment 4 Larry the Git Cow gentoo-dev 2023-02-23 09:24:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=3b0efeeaeb01626ba215b0613ee05f733196860f

commit 3b0efeeaeb01626ba215b0613ee05f733196860f
Author:     Adrian Schollmeyer <nex+b-g-o@nexadn.de>
AuthorDate: 2023-02-17 17:01:01 +0000
Commit:     Adrian Schollmeyer <nex+b-g-o@nexadn.de>
CommitDate: 2023-02-17 17:01:01 +0000

    dev-cpp/dpp: backport upstream PR #596 build system rework
    
    This rework finally gives back control over optimization flags and the
    like to CXXFLAGS/LDFLAGS instead of overwriting it in the ebuild. This
    might be relevant for systems where certain optimization flags are
    needed for performance reasons.
    
    Closes: https://bugs.gentoo.org/890014
    Signed-off-by: Adrian Schollmeyer <nex+b-g-o@nexadn.de>

 dev-cpp/dpp/Manifest                               |   1 +
 dev-cpp/dpp/dpp-10.0.21.ebuild                     |   3 +
 dev-cpp/dpp/dpp-10.0.22.ebuild                     |   6 +
 .../dpp-rework-compiler-flag-setting-890014.patch  | 147 +++++++++++++++++++++
 4 files changed, 157 insertions(+)