Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 88965 - Patch to enable mmx support in ffmpeg on amd64
Summary: Patch to enable mmx support in ffmpeg on amd64
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: AMD64 Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-13 07:53 UTC by Herbie Hopkins (RETIRED)
Modified: 2005-04-21 14:30 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
enable mmx support on amd64 (ffmpeg-mmx.patch,1.04 KB, patch)
2005-04-13 08:01 UTC, Herbie Hopkins (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Herbie Hopkins (RETIRED) gentoo-dev 2005-04-13 07:53:31 UTC
x86_64 assembly was added to ffmpeg cvs sometime in January and is therefore contained in the current portage release (ffmpeg-0.4.9_p20050226). The attached patch enables mmx support on amd64.
Comment 1 Herbie Hopkins (RETIRED) gentoo-dev 2005-04-13 08:01:01 UTC
Created attachment 56165 [details, diff]
enable mmx support on amd64

This patch enables mmx support on amd64 irrespective of use flags. I also had
to replace PIC with __PIC__ in a few places to enable successful compilation
(could alternatively compile with -DPIC).
Comment 2 Luca Barbato gentoo-dev 2005-04-13 12:17:28 UTC
could you try to commit the patch upstream?
Comment 3 Herbie Hopkins (RETIRED) gentoo-dev 2005-04-13 12:40:01 UTC
ffmpeg direct from cvs works fine with mmx on amd64 (with -DPIC in CFLAGS). I can only assume that the use of PIC over __PIC__ in a few places is a design decision and not a bug and imagine that is exactly the response I'd get if this was mentioned upstream (just use -DPIC and be happy...). I chose to add the sed lines in the ebuild to replace the PIC with __PIC__ simply because there were already sed lines in place to do this (the current sed lines replace some but not all occurrences and are therefore a little broken IMO).

I'm also a little confused by the current use of has_pic to determine if mmx support should be used. has_pic seems to return true on even on x86 boxes i've tested this on that have never had USE=pic (and as such mmx support is disabled). Is this condition really neccessary?
Comment 4 Luca Barbato gentoo-dev 2005-04-14 02:54:15 UTC
I'd like to make another ffmpeg snapshot once the native vorbis codec will be there or at least once the ogg demuxer and the snow codec changes are less problematic.
Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-04-21 14:30:49 UTC
Thanks applied on new -r4 ebuild, works fine for me.