Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 887795 - [guru] mpv-plugin/mpv-mpris-0.9-r1 overwrites user's optimization (-O*)
Summary: [guru] mpv-plugin/mpv-mpris-0.9-r1 overwrites user's optimization (-O*)
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Oliver Freyermuth
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2022-12-21 21:02 UTC by Agostino Sarubbo
Modified: 2022-12-27 08:05 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,55.12 KB, text/plain)
2022-12-21 21:02 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-21 21:02:39 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: mpv-plugin/mpv-mpris-0.9-r1 overwrites user's optimization (-O*).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
man gcc says:
"If you use multiple -O options, with or without level numbers, the last such option is the one that is effective".

So, since the build system adds -O* after -O* provided by my CFLAGS/CXXFLAGS means that it is overwritten and unless there are known issues with -O* configured by the user, the build system should not overwrite -O*.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-21 21:02:41 UTC
Created attachment 844591 [details]
build.log

build log and emerge --info
Comment 2 Oliver Freyermuth 2022-12-21 22:44:07 UTC
Many thanks for the detailed report! 

This will be fixed by:
https://gitweb.gentoo.org/repo/proj/guru.git/commit/?h=dev&id=75760867b56172fabfb5dee516c8e9ca500c814e
once it is synced to guru's master.
Comment 3 Larry the Git Cow gentoo-dev 2022-12-27 08:05:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=75760867b56172fabfb5dee516c8e9ca500c814e

commit 75760867b56172fabfb5dee516c8e9ca500c814e
Author:     Oliver Freyermuth <o.freyermuth@googlemail.com>
AuthorDate: 2022-12-21 22:42:08 +0000
Commit:     Oliver Freyermuth <o.freyermuth@googlemail.com>
CommitDate: 2022-12-21 22:42:08 +0000

    mpv-plugin/mpv-mpris: Patch out -O2 from Makefile.
    
    This overrides optimization flags specified by the user otherwise.
    Also, revbump and re-sync live ebuild.
    
    Closes: https://bugs.gentoo.org/887795
    Signed-off-by: Oliver Freyermuth <o.freyermuth@googlemail.com>

 .../{mpv-mpris-0.9-r1.ebuild => mpv-mpris-0.9-r2.ebuild}     |  5 +++++
 mpv-plugin/mpv-mpris/mpv-mpris-9999.ebuild                   | 12 ++++++++++--
 2 files changed, 15 insertions(+), 2 deletions(-)