Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 887793 - [guru] mpv-plugin/kde-night-color-20220109-r1 overwrites user's optimization (-O*)
Summary: [guru] mpv-plugin/kde-night-color-20220109-r1 overwrites user's optimization ...
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Nicola Smaniotto
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2022-12-21 21:02 UTC by Agostino Sarubbo
Modified: 2023-01-12 10:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,55.70 KB, text/plain)
2022-12-21 21:02 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-21 21:02:35 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: mpv-plugin/kde-night-color-20220109-r1 overwrites user's optimization (-O*).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
man gcc says:
"If you use multiple -O options, with or without level numbers, the last such option is the one that is effective".

So, since the build system adds -O* after -O* provided by my CFLAGS/CXXFLAGS means that it is overwritten and unless there are known issues with -O* configured by the user, the build system should not overwrite -O*.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-21 21:02:37 UTC
Created attachment 844589 [details]
build.log

build log and emerge --info
Comment 2 Larry the Git Cow gentoo-dev 2023-01-12 10:38:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=2ffe7ea11921f8e382c3509640cea9f8c7ff3500

commit 2ffe7ea11921f8e382c3509640cea9f8c7ff3500
Author:     Nicola Smaniotto <smaniotto.nicola@gmail.com>
AuthorDate: 2023-01-10 16:03:31 +0000
Commit:     Nicola Smaniotto <smaniotto.nicola@gmail.com>
CommitDate: 2023-01-11 18:19:21 +0000

    mpv-plugin/kde-night-color: add 20230110, drop 20220109-r1
    
    Closes: https://bugs.gentoo.org/887793
    Signed-off-by: Nicola Smaniotto <smaniotto.nicola@gmail.com>

 mpv-plugin/kde-night-color/Manifest                                   | 2 +-
 ...night-color-20220109-r1.ebuild => kde-night-color-20230110.ebuild} | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)