Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 887429 - [guru] dev-lang/quickjs-2021.03.27 overwrites user's optimization (-O*)
Summary: [guru] dev-lang/quickjs-2021.03.27 overwrites user's optimization (-O*)
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: GURU project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2022-12-20 12:49 UTC by Agostino Sarubbo
Modified: 2022-12-29 11:33 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,62.66 KB, text/plain)
2022-12-20 12:49 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-20 12:49:23 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-lang/quickjs-2021.03.27 overwrites user's optimization (-O*).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
man gcc says:
"If you use multiple -O options, with or without level numbers, the last such option is the one that is effective".

So, since the build system adds -O* after -O* provided by my CFLAGS/CXXFLAGS means that it is overwritten and unless there are known issues with -O* configured by the user, the build system should not overwrite -O*.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-20 12:49:26 UTC
Created attachment 844119 [details]
build.log

build log and emerge --info
Comment 2 Larry the Git Cow gentoo-dev 2022-12-29 11:33:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=83488982f898bc6f78dbba3f427173e84bd11e8d

commit 83488982f898bc6f78dbba3f427173e84bd11e8d
Author:     Denis Reva <denis7774@gmail.com>
AuthorDate: 2022-12-27 14:20:35 +0000
Commit:     Denis Reva <denis7774@gmail.com>
CommitDate: 2022-12-27 14:20:45 +0000

    */*: Added LTO use flag, respecting environment
    
    Closes: https://bugs.gentoo.org/887427
    Closes: https://bugs.gentoo.org/887429
    Signed-off-by: Denis Reva <denis7774@gmail.com>

 app-emulation/waydroid/files/waydroid              |  9 +++++
 .../files/quickjs-2021-03-27-respect-env.patch     | 47 ++++++++++++++++++++++
 dev-lang/quickjs/metadata.xml                      |  3 ++
 dev-lang/quickjs/quickjs-2021.03.27.ebuild         | 14 ++++++-
 4 files changed, 72 insertions(+), 1 deletion(-)