Bugzilla Bug 88532

Aqualung seems like a mature, high quality, full featured audio player with
lots of benefits over xmms (et al).  Why isn't it in portage yet?  I can't
compile it myself to see if it would 'just work' because it requires liblrdf
0.4.0 (current version in portage is 0.3.x).  Please make an ebuild for
aqualung!  I'll love you forever.

Reproducible: Always
Steps to Reproduce:
1. emerge aqualung


Actual Results:  
nothing

Expected Results:  
something

Corey, please lose the flair for melodrama when you file a bug.  a "BLOCKER"
bug is the absolute most critical type of bug that prevents you from installing
a gentoo system.  What you are asking for is an *ENHANCEMENT*  

Created an attachment (id=56207) [details]
aqualung-0.9_beta41.ebuild

It does now ;-)

Can you please try this ebuild and let me know if it worked or not. It is a
rough one and still needs work. It does depend now on
>=media-libs/liblrdf-0.4.0 which  is not in portage yet. I will open a new bug
for that and make this depend on it. 

I had to emerge with FEATURES=-sandbox because of some locales issue i have not
figured out yet.

Changing skins is causing problems with me.

Depend on liblrdf 0.4.0

Sorry about the long turn around time on this, life's been hitting me in the
face recently.

After some work I managed to get it to compile and merge.  The program seems to
work fine.  In fact, it does everything that I need it to.  Thank you so much!!

The bigger problem now is that alsa-driver-1.0.9 does not like my
JACK-audio-connection-kit and is introducing xruns at regular intervals
regardless of load or buffer size.  I suppose that will smooth itself out in
time, but for now I once again thank you for your work.

Do the skins work for you because when i tried they did not show and gave
errors. I have a improved ebuild ready which i will upload soon but first i
want make sure   if skinning works.

Created an attachment (id=59460) [details]
aqualung-0.9_beta41.ebuild cleaned up

New cleaned up ebuild but skins are not working..... don't know why

*** Bug 167504 has been marked as a duplicate of this bug. ***

Created an attachment (id=110562) [details]
media-sound/aqualung-0.9_beta71.ebuild

Anyone?

some improvements could be done to this ebuild : 

- please be more verbose in description (but not too much :) )
- !media-sound/aqualung-cvs  -> not in portage, this blocker must be removed
- cddb? ( !amd64? ( >=media-libs/libcddb-1.2.1 ) )
        cddb? ( amd64? ( >=media-libs/libcddb-1.3.0 ) )
   I'm not sure I get the point of those lines


- use emake install, not make install
- ${D} and ${S} should be quoted
- is gtk only needed at compile time ? That sounds weird to me
- S=$(echo "${S}" | sed s^/aqualung-0.9_beta71$^/aqualung-0.9beta7.1^)  -> use
replace_version_separator from versionator eclass, that's much better in a
portability point of view.

- Use ${P} or something similar in SRC_URI, see
http://devmanual.gentoo.org/ebuild-writing/variables/index.html

- is this compatible with flac 1.1.3 and 1.1.4 ? see bug #152007
- oggvorbis useflag is deprecated, see use.desc in $PORTDIR/profiles
- gtk deps in DEPEND seems duplicated several times
- virtual/libc is already in system dependencies, you should not depend on it.

Libcddb on the amd64 needs a higher version to work, so i changed the dep for
that platform.

The many gtk deps have a simple reason, 2.6 is required, 2.8 for one feature
and 2.10 for another feature. Both of those features are use flagged.

Flac support is up-to-date, i took care of that some time ago.

Fixed some things in my local copy already, will do the rest later.

Created an attachment (id=113195) [details]
New ebuild, hopefully this one is ok.

Not the perfect use of versionater, but i didn't know how else it could be
done.
The beta71 is the 3rd component and needs to be beta7.1

Any futher comments? (if possible to like get this into the tree)

(In reply to comment #14)
> Any futher comments? (if possible to like get this into the tree)
> 

Very bad sentence, i meant: If possible i'd like to get it into the portage
tree.

(In reply to comment #12)
> Libcddb on the amd64 needs a higher version to work, so i changed the dep for
> that platform.

Why ? Why is that amd64 specific ? Is it libcddb fault's ? I fail to see why
being amd64 would need a newer version.


> The many gtk deps have a simple reason, 2.6 is required, 2.8 for one feature
> and 2.10 for another feature. Both of those features are use flagged.

Ok, good

> Flac support is up-to-date, i took care of that some time ago.

Good :-)


Some new comments : 
- Please use mirror://sourceforge in SRC_URI
- About versionator : what's the problem with replace_version_separator ? 
- src_unpack() is not needed if you just do unpack and cd

The problem is that beta71 is seen as one component, and it needs to be beta7.1
for the SRC_URI. So the easiest way was to take component1, component2 and and
modify component 3.

Created an attachment (id=113480) [details]
media-sound/aqualung-0.9_beta71.ebuild

Removes src_unpack() and modified SRC_URI.

Any chance of getting this into portage?

This is a great media player, it should be in portage. It's for other people, i
use the svn version anyway. Why is no one willing to put it into portage?

Are there (serious) problems with the ebuild or do i need to start poking
people?

(In reply to comment #21)
> Are there (serious) problems with the ebuild or do i need to start poking
> people?
> 

you shouldn't; if you want to have this in the tree as soon as possible join
gentoo and especially the sound herd; the problem is that gentoo maintains
about ~10000 pckages, but has <350 developers. 

that being said, i was happy to find your ebuild here as aqualung seems to be
an interesting piece of software and may be the kind of audio player i was
looking for (after getting annoyed with audacious).

Created an attachment (id=125268) [details]
media-sound/aqualung/aqualung-0.9_beta8.ebuild
achumakov       Alexey Chumakov         0x7003C5D4      Moscow, Russia 
Documentation and Internationalization, Russian Lea

ebuild for the latest version; thanks to Maarten Maathuis the only thing i had
to do was to remove a single "." from the aqualung-0.9_beta71.ebuild as
upstream seems to have changed their package naming convention.

(In reply to comment #23)
> Created an attachment (id=125268) [edit] [details]
> media-sound/aqualung/aqualung-0.9_beta8.ebuild
> achumakov       Alexey Chumakov         0x7003C5D4      Moscow, Russia 

ups, sorry -- seems that copy and paste has tricked me into doing something
stupid; but the ebuild should work nonetheless.

A new version has been released:

Aqualung 0.9beta9.1

and the web site has changed:

http://aqualung.factorial.hu

After almost three years, will this ever get into portage?
Thanks!

Finally, added to the portage tree. Thank you all for your contributions!