Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 880309 - app-editors/bvi-1.4.1-r1 does not respect CFLAGS
Summary: app-editors/bvi-1.4.1-r1 does not respect CFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Christopher Head
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: cflags
  Show dependency tree
 
Reported: 2022-11-08 06:55 UTC by Agostino Sarubbo
Modified: 2022-12-24 07:55 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,47.53 KB, text/plain)
2022-11-08 06:55 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-11-08 06:55:26 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-editors/bvi-1.4.1-r1 does not respect CFLAGS.
Discovered on: amd64 (internal ref: ci)

NOTE:
To reproduce this issue you may want to add "-frecord-gcc-switches" to CFLAGS/CXXFLAGS/FFLAGS/FCFLAGS. If this is not something about c/c++ context see this bug as an hint to hide the QA warning (with QA_FLAGS_IGNORED) where is not possible to respect CFLAGS.
Comment 1 Agostino Sarubbo gentoo-dev 2022-11-08 06:55:29 UTC
Created attachment 828567 [details]
build.log

build log and emerge --info
Comment 2 Larry the Git Cow gentoo-dev 2022-12-24 07:55:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7f99689aa221da85c8535863452819baa1f7bf1e

commit 7f99689aa221da85c8535863452819baa1f7bf1e
Author:     Christopher Head <chead@chead.ca>
AuthorDate: 2022-11-09 05:15:29 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-12-24 07:55:10 +0000

    app-editors/bvi: fix CFLAGS handling
    
    * Add `-std=gnu89` as recommended as the way to build K&R-style code
      which will not break with Clang 16.
    * Append, instead of overwriting, `CFLAGS`.
    * Bump to EAPI 8 while at it.
    
    Closes: https://bugs.gentoo.org/880309
    Closes: https://bugs.gentoo.org/880393
    Signed-off-by: Christopher Head <chead@chead.ca>
    Closes: https://github.com/gentoo/gentoo/pull/28199
    Signed-off-by: Sam James <sam@gentoo.org>

 app-editors/bvi/bvi-1.4.1-r2.ebuild | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)