Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 874612 - app-eselect/eselect-wine: "eselect wine set N" should output a confirmation of the selected option
Summary: app-eselect/eselect-wine: "eselect wine set N" should output a confirmation o...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Wine Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 874351
  Show dependency tree
 
Reported: 2022-10-03 10:19 UTC by Andrew Church
Modified: 2022-11-23 20:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Church 2022-10-03 10:19:39 UTC
"eselect wine set N" should output a confirmation of the selected option, as (for example) gcc-config does:

$ gcc-config 2
 * Switching native-compiler to x86_64-pc-linux-gnu-12.2.0 ... [ ok ]

See also bug 874351.
Comment 1 Ionen Wolkens gentoo-dev 2022-10-28 22:08:42 UTC
Ideally eselect-wine needs to be rewritten from the ground up, the current ebuilds just mitigate its issues (give their own confirmation feedback, ignore certain errors, need to call it /4/ times, and is still broken on prefix either way).

Unsure if/when I'll get to that (just something in the back of my mind if no one else tackles this first), or if I'll be doing quick fixes to the current implementation at all (need to setup a new repo too given the upstream is essentially gone).

I'll keep this and other bugs in mind, but don't expect a fix soon (just wanted to give a reply).
Comment 2 Larry the Git Cow gentoo-dev 2022-11-16 15:02:36 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1954598a4b9fee10c063f6be17d07b47e7e93e4b

commit 1954598a4b9fee10c063f6be17d07b47e7e93e4b
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2022-11-16 03:30:33 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2022-11-16 15:01:04 +0000

    app-eselect/eselect-wine: add 2.0.0, unkeyworded for testing
    
    Complete rewrite but for notable bits:
    - removes register/deregister, can auto-update without this
    - no longer touch files in /usr at runtime wrt bug #632576, in this
      case it was particularly invasive doing *many* modifications to
      /usr/bin and /usr/share/man
    - handle /usr/lib/wine fwiw wrt bug #657748 (installed by the
      ebuild), albeit winebuild can find the right path nowadays
    - fix prefix wrt bug #717470
    - give feedback when switching wrt bug #874612
    - tries harder to not unexpectedly switch variant/version, and
      no longer need ebuild checks wrt bug #881035
    - no longer hardcodes variants and so can support any random ones,
      i.e. an overlay can do wine-tkg or wine-myfunnyfork
    - --all, --vanilla, etc.. options were removed, but can still
      perform similar actions (see `help`)
    - `list` can now show selections for all variants at once
    - `unset` removed, not seeing a motivation (esp if not polluting /usr)
    - half+ the original size, and switches variant noticeably faster
    
    Still experimental and subject to changes, so unkeyworded for now.
    See README.rst for more notes, or the tarball's impl.rst for details.
    
    ebuild itself needs some nonsense largely caused by being difficult
    to get rid of the old eselect plus portage limitations.
    
    Bug: https://bugs.gentoo.org/632576
    Bug: https://bugs.gentoo.org/657748
    Bug: https://bugs.gentoo.org/717470
    Bug: https://bugs.gentoo.org/874612
    Bug: https://bugs.gentoo.org/881035
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 app-eselect/eselect-wine/Manifest                  |  1 +
 app-eselect/eselect-wine/eselect-wine-2.0.0.ebuild | 88 ++++++++++++++++++++++
 2 files changed, 89 insertions(+)
Comment 3 Larry the Git Cow gentoo-dev 2022-11-23 20:39:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5bf131a2a1d9365fcf992468091ce2814782dc3e

commit 5bf131a2a1d9365fcf992468091ce2814782dc3e
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2022-11-23 16:10:41 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2022-11-23 20:38:21 +0000

    app-eselect/eselect-wine: unleash eselect-wine-2
    
    Had expected to need a 2.0.1 before this, but no issues reported
    so far. Let's see how it goes.
    
    I do imagine it may cause some confusion given portage doesn't
    make emerging it pretty and need to source /etc/profile at
    least once, but have no "good" solutions to these beside warnings.
    
    (also expecting a benign tinderbox bug about symlinks which can't
    be silenced currently)
    
    Closes: https://bugs.gentoo.org/632576
    Closes: https://bugs.gentoo.org/657748
    Closes: https://bugs.gentoo.org/717470
    Closes: https://bugs.gentoo.org/874612
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 app-eselect/eselect-wine/eselect-wine-2.0.0.ebuild | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)