Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 84752 - media-sound/timidity++ requires an ebuild rewrite
Summary: media-sound/timidity++ requires an ebuild rewrite
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 76361 76654 77286 83018
  Show dependency tree
 
Reported: 2005-03-10 07:01 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2005-03-21 14:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Cleanup patch (timidity++-2.13.2.patch,4.45 KB, patch)
2005-03-20 06:04 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
Cleanup patch - 2nd try (timidity++-2.13.2-2.patch,4.31 KB, patch)
2005-03-21 13:24 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2005-03-10 07:01:01 UTC
This bug is a "placeholder" because there is too many different bug reports which requires a timidity ebuild rewrite.

I don't have access to a gentoo linux system right now so I can't fix it for sure, but I'll take a look to start the work at least.

I'll make this bug block the bugs which needs the rewrite, so when the rewrite is done we'll know that they can be closed.

Hope this won't bother anybody.

Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-03-10 07:12:40 UTC
Bug #77286 also has already a patch for a little rewrite.

Change done for bug #48761 should be reverted or edited because seems to be already fixed upstream.
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-03-20 06:04:56 UTC
Created attachment 53929 [details, diff]
Cleanup patch

Ok here is the patch. It adds the useflag for formats as stated by bug #77286,
it moves gtk dependency to 2.0 (as it seems the one configure checks for), it
removes the use arts || use gtk stuff (as I said, it's fixed upstream), it
clean ups econf call, it cleanup conditional and uses newinitd newconfd to
install init.d and conf.d scripts.
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-03-21 13:24:39 UTC
Created attachment 54095 [details, diff]
Cleanup patch - 2nd try

Ok this time without X-dependent gtk, tcltk and motif. Also added conditional
dependency on ncurses (I totally forgot it before).

HTH
Comment 4 Jeremy Huddleston (RETIRED) gentoo-dev 2005-03-21 14:58:26 UTC
fixed in portage, thanks.