Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 80414 - fbi depends on both libungif and libgif
Summary: fbi depends on both libungif and libgif
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Michal Januszewski (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on: 18820
Blocks:
  Show dependency tree
 
Reported: 2005-02-01 20:20 UTC by Stefan Sperling
Modified: 2005-03-23 06:25 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
this patch makes fbi depend on either giflib or libungif (fbi-1.31.ebuild.diff,388 bytes, patch)
2005-02-01 20:23 UTC, Stefan Sperling
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Sperling 2005-02-01 20:20:51 UTC
fbi-1.31.ebuild has a hardcoded dependency on both libungif and giflib.
This is not necessary.
Comment 1 Stefan Sperling 2005-02-01 20:23:16 UTC
Created attachment 50190 [details, diff]
this patch makes fbi depend on either giflib or libungif

I tested this patch twice, having only giflib installed the first time 
and libungif the second time. Works fine here.
Comment 2 Michal Januszewski (RETIRED) gentoo-dev 2005-02-05 15:03:16 UTC
Actually, it's not that easy. Please notice that with only giflib installed, gif.c  never gets compiled and with only libungif installed, the compilation fails (bug #78243).
Comment 3 Stefan Sperling 2005-02-05 16:07:12 UTC
I knew about bug #78243, but I couldn't reproduce it the other day.
Now I even know why :)

I just looked into this again, and you are partially right:
Compilation fails if giflib is not installed _and_ USE=gif is set.

This is the relevant line from the libungif ebuild:

    use gif && rm -r "${D}"/usr/bin "${D}"/usr/include/gif_lib.h

It removes gif_lib.h, assuming giflib already provides it.
fbi then fails to include the header.

The fbi makefile only checks for libungif and ignores giflib as you rightly
pointed out. fbi compiles fine with gif_lib.h from libungif (just tested).

fbi should check the gif useflag and depend on both libgif
and libungif if the flag is set, and on only libungif is the flag is not set.

I could imagine that there are other ebuilds in the tree that trip
over giflib/libungif madness. It's a nuisance, really. Damn patents...

There actually is an open bug on this: bug #18820
Comment 4 Michal Januszewski (RETIRED) gentoo-dev 2005-02-06 09:15:28 UTC
If the 'gif' flag is not set, fbi shouldn't depend on either library, as it is likely that the user simply doesn't want support for the GIF fileformat.
Comment 5 Stefan Sperling 2005-02-06 09:54:08 UTC
that's exactly why the gif useflag is currently ambigious.
again, please see bug #18820 and add your comments.
Comment 6 Michal Januszewski (RETIRED) gentoo-dev 2005-03-23 06:25:26 UTC
Fixed in -r1.
Comment 7 Michal Januszewski (RETIRED) gentoo-dev 2005-03-23 06:25:38 UTC
Fixed in -r1.