Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 78058 - "Konqueror crash on specific javascript" patch released
Summary: "Konqueror crash on specific javascript" patch released
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-15 01:06 UTC by Gleb Litvjak
Modified: 2005-07-14 10:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
The patch by Sarah (I tweaked it a little so it can be included in the ebuild) (khtml_js_crash.patch,1.64 KB, patch)
2005-01-15 01:08 UTC, Gleb Litvjak
Details | Diff
New patch. (konqueror-javascript.crash.patch,6.44 KB, patch)
2005-02-20 08:27 UTC, Peter Volkov (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gleb Litvjak 2005-01-15 01:06:41 UTC
Today the kde team finally released a patch that fixes the most often reported konqueror bug: http://bugs.kde.org/show_bug.cgi?id=68523

I had to tweak the patch a little to be able to add it to the ebuild. It would be great if it was included in kdelibs ebuild,as the bug is very annoying.
Comment 1 Gleb Litvjak 2005-01-15 01:08:52 UTC
Created attachment 48529 [details, diff]
The patch by Sarah (I tweaked it a little so it can be included in the ebuild)
Comment 2 Simone Gotti (RETIRED) gentoo-dev 2005-01-24 04:43:22 UTC
Sorry if we didn't applied patches to kde ebuilds. I think that the main reason (at least on my side) is that kdebase ebuilds are big and we don't want to force users to recompile kdebase (or other) for a single patch that for most people won't change nothing.

Also for this reason we made the splitted kde ebuilds. In this way applying patch won't take a lot of users time as we'll recompile only the affected program.
Comment 3 Gleb Litvjak 2005-01-24 06:11:31 UTC
Well, I see your point. But the patch could be applied w/o the version bump, so the users who install kde for the first time won't have the bug. As this bug was the most often reported konqueror bug the issue is quite serious.
Comment 4 Simone Gotti (RETIRED) gentoo-dev 2005-01-24 06:19:51 UTC
Applying without version bumping has no sense for me as we'll get different konqueror behaviors and of course it's against the gentoo policy.
The right thing to do in this cases is a revision bump. If you say that this bug is reported a lof of times we can also bump the ebuild.
Comment 5 Gleb Litvjak 2005-01-24 06:32:09 UTC
This bug has 27 duplicates,  37 comments and got 190 votes (according to kde bugzilla, http://bugs.kde.org/show_bug.cgi?id=68523) - I think it is pretty much.
Comment 6 Gregorio Guidi (RETIRED) gentoo-dev 2005-01-24 06:50:40 UTC
Honestly, I thought about adding the fix to a new revision of kdebase, but the
patch has not been accepted by kde developers yet, so it's neither applied to
HEAD, nor to KDE_3_3_BRANCH. My opinion is that we must wait for them to take
actions, before taking action ourselves.
Comment 7 Peter Volkov (RETIRED) gentoo-dev 2005-02-20 08:27:52 UTC
Created attachment 51672 [details, diff]
New patch.

This is the last patch, that was applied on cvs (see already mentioned bug).

As this is very hated bug in kde and we don't know how long to wait for the
next release I think it's time to add this patch, so gentoo users could avoid
this very nasty problem.

So, I think it's time to close this bug :)
Peter.
Comment 8 Peter Volkov (RETIRED) gentoo-dev 2005-02-20 08:37:20 UTC
Forgot to mention.

This patch should be applied cleanly, I hope... Just add necessary epatch in ebuild. Something like:
epatch ${FILESDIR}/konqueror-javascript.crash.patch
Comment 9 Gregorio Guidi (RETIRED) gentoo-dev 2005-02-21 02:03:59 UTC
Did you ask them to backport the patch to kde-3.3.x?
Comment 10 Peter Volkov (RETIRED) gentoo-dev 2005-02-21 02:06:32 UTC
No. I did not. I've take that patch and applied it to the current kdelibs. Compiled and tested. Everything works for me. No crashes.

If you need I can ask them to backport.
Comment 11 Gregorio Guidi (RETIRED) gentoo-dev 2005-02-21 03:16:11 UTC
Yes, it seems reasonable to ask for a backport for everyone and not for
Gentoo only.
Comment 12 Caleb Tennis (RETIRED) gentoo-dev 2005-07-14 10:01:44 UTC
. 
Comment 13 Caleb Tennis (RETIRED) gentoo-dev 2005-07-14 10:02:00 UTC
.