Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 757306 - sys-apps/portage: emerge backtracking for circular dependencies does not work for virtuals
Summary: sys-apps/portage: emerge backtracking for circular dependencies does not work...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Interface (emerge) (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 756028
  Show dependency tree
 
Reported: 2020-11-28 02:28 UTC by Zac Medico
Modified: 2021-01-26 00:46 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zac Medico gentoo-dev 2020-11-28 02:28:20 UTC
In the change to the dep_zapdeps function for bug 703440, the parent variable refers to the parent that pulled in the virtual, rather than the virtual itself. This prevents circular edges in virtuals from being avoided:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=f78a91e44e3e82008e89f05fe3871e2cb03a8646
Comment 2 Larry the Git Cow gentoo-dev 2020-11-28 20:37:48 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=b59e2545a88dccf70e546d49e08a5a99110dd628

commit b59e2545a88dccf70e546d49e08a5a99110dd628
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2020-11-28 01:04:07 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2020-11-28 03:13:02 +0000

    backtracking: fix virtual choices for circular deps (bug 757306)
    
    Fix virtual choices to be consistent with circular dependency
    backtracking choices.
    
    Fixes: f78a91e44e3e ("backtracking: adjust || preference to break dependency cycles")
    Bug: https://bugs.gentoo.org/757306
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 lib/portage/dep/dep_check.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2020-11-28 21:17:19 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d77f07243dac0d12e44d0b0c5e6ab79c76111809

commit d77f07243dac0d12e44d0b0c5e6ab79c76111809
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2020-11-28 21:10:27 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2020-11-28 21:17:14 +0000

    sys-apps/portage: Bump to version 3.0.11
    
     #756961 handle dev-lang/rust[system-bootstrap] dependency cycle
     #757306 backtracking: fix virtual choices for circular deps
    
    Bug: https://bugs.gentoo.org/756793
    Bug: https://bugs.gentoo.org/756961
    Bug: https://bugs.gentoo.org/757306
    Bug: https://bugs.gentoo.org/756028
    Package-Manager: Portage-3.0.11, Repoman-3.0.2
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-3.0.11.ebuild | 267 +++++++++++++++++++++++++++++++++
 2 files changed, 268 insertions(+)